Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLRC: ML Delete job from calendar #35713

Merged

Conversation

benwtrent
Copy link
Member

Adds the ML API for Deleting job(s) from a calendar.

Relates to #29827

@benwtrent
Copy link
Member Author

Pinging @elastic/ml-core

Copy link
Contributor

@edsavage edsavage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Made one minor suggestion

* It can be a list of jobs or groups.
*/
public DeleteCalendarJobRequest(String calendarId, String... jobIds) {
this.calendarId = Objects.requireNonNull(calendarId, "[calendar_id] must not be null.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use Calendar.ID here?

@benwtrent benwtrent merged commit d707838 into elastic:master Nov 20, 2018
@benwtrent benwtrent deleted the feature/hlrc-ml-delete-job-from-calendar branch November 20, 2018 13:43
benwtrent added a commit that referenced this pull request Nov 20, 2018
@elastic elastic deleted a comment Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants