Removes two unused AnalysisConfig options #35645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core |
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/job/config/AnalysisConfig.java
Outdated
Show resolved
Hide resolved
droberts195
reviewed
Nov 16, 2018
client/rest-high-level/src/main/java/org/elasticsearch/client/ml/job/config/AnalysisConfig.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/main/java/org/elasticsearch/client/ml/job/config/AnalysisConfig.java
Outdated
Show resolved
Hide resolved
benwtrent
added a commit
that referenced
this pull request
Nov 19, 2018
* ML: Removing result_finalization_window && overlapping_buckets * Reverting bad method deletions * Setting to current before backport to try and get a green build * fixing testBuildAutodetectCommand test
benwtrent
added a commit
that referenced
this pull request
Nov 19, 2018
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Nov 19, 2018
benwtrent
added a commit
that referenced
this pull request
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
result_finalization_windowis pretty much unused, and over time has become broken due to other features. Consequently, it andoverlapping_bucketsare being removed as options for AnalysisConfig.Since these were undocumented and largely unfinished/broken options, removal is acceptable and helps simplify much of the downstream ml-cpp code.
Relates to elastic/ml-cpp#302