-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script docs #35629
Script docs #35629
Conversation
Pinging @elastic/es-core-infra |
I haven't added examples for |
Test failure is an unrelated CCR one - given that the docs build has passed, I think this is good to go? |
@romseygeek Asked @debadair to take a look as well from the doc side of things. Thanks for doing this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few editorial nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for doing this! @nik9000 Are you happy with the changes now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit adds some more details and examples to the docs for the
score
,weight
,similarity
andsort
painless contexts.Relates to #34829