Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script docs #35629

Merged
merged 6 commits into from
Dec 3, 2018
Merged

Script docs #35629

merged 6 commits into from
Dec 3, 2018

Conversation

romseygeek
Copy link
Contributor

This commit adds some more details and examples to the docs for the score, weight, similarity and sort painless contexts.

Relates to #34829

@romseygeek romseygeek added >docs General docs changes :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v7.0.0 v6.6.0 labels Nov 16, 2018
@romseygeek romseygeek self-assigned this Nov 16, 2018
@romseygeek romseygeek requested a review from jdconrad November 16, 2018 10:51
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@romseygeek
Copy link
Contributor Author

I haven't added examples for weight or similarity because they don't really fit with the painless example dataset, and the docs for scripted_similarity cover that pretty well.

@romseygeek
Copy link
Contributor Author

Test failure is an unrelated CCR one - given that the docs build has passed, I think this is good to go?

@jdconrad jdconrad requested a review from debadair November 19, 2018 23:32
@jdconrad
Copy link
Contributor

@romseygeek Asked @debadair to take a look as well from the doc side of things. Thanks for doing this!

Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few editorial nits.

Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this! @nik9000 Are you happy with the changes now?

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >docs General docs changes v6.6.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants