-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a _freeze
/ _unfreeze
API
#35592
Conversation
This commit adds a rest endpoint for freezing and unfreezing an index. Among other cleanups mainly fixing an issue accessing package private APIs from a plugin that got caught by integration tests this change also adds documentation for frozen indices. Note: frozen indices are marked as `beta` and available as a basic feature. Relates to elastic#34352
Pinging @elastic/es-distributed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once changes are merged
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
Co-Authored-By: s1monw <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left only minor comments.
...lugin/core/src/main/java/org/elasticsearch/xpack/core/action/TransportFreezeIndexAction.java
Outdated
Show resolved
Hide resolved
...lugin/core/src/main/java/org/elasticsearch/xpack/core/action/TransportFreezeIndexAction.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/src/test/resources/rest-api-spec/test/indices.freeze/10_basic.yml
Show resolved
Hide resolved
x-pack/plugin/src/test/resources/rest-api-spec/test/indices.freeze/10_basic.yml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I left some comments and questions.
server/src/main/java/org/elasticsearch/cluster/metadata/MetaDataIndexStateService.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/XPackClientPlugin.java
Outdated
Show resolved
Hide resolved
...lugin/core/src/main/java/org/elasticsearch/xpack/core/action/TransportFreezeIndexAction.java
Outdated
Show resolved
Hide resolved
...lugin/core/src/main/java/org/elasticsearch/xpack/core/action/TransportFreezeIndexAction.java
Show resolved
Hide resolved
...lugin/core/src/main/java/org/elasticsearch/xpack/core/action/TransportFreezeIndexAction.java
Show resolved
Hide resolved
x-pack/plugin/core/src/test/java/org/elasticsearch/index/engine/FrozenIndexRecoveryTests.java
Outdated
Show resolved
Hide resolved
This commit adds a rest endpoint for freezing and unfreezing an index. Among other cleanups mainly fixing an issue accessing package private APIs from a plugin that got caught by integration tests this change also adds documentation for frozen indices. Note: frozen indices are marked as `beta` and available as a basic feature. Relates to #34352
This commit adds a rest endpoint for freezing and unfreezing an index.
Among other cleanups mainly fixing an issue accessing package private APIs
from a plugin that got caught by integration tests this change also adds
documentation for frozen indices.
Note: frozen indices are marked as
beta
and available as a basic feature.Relates to #34352