[Zen2] Introduce auto_shrink_voting_configuration setting #35217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we allow the user to set the minimum size of a voting configuration. On reflection we would rather this was simply '3' where possible, and we can use the retirement API to control the removal of nodes more explicitly. This change replaces the old reconfigurator setting with a new one, `cluster.auto_shrink_voting_configuration`, which determines whether Elasticsearch should automatically remove nodes from the voting configuration or not.
DaveCTurner
added
>enhancement
v7.0.0
:Distributed Coordination/Cluster Coordination
DaveCTurner
changed the title
ywelsch
approved these changes
Nov 5, 2018
| assertThat(lastCommittedConfiguration + " should be 1 node", lastCommittedConfiguration.getNodeIds().size(), equalTo(1)); | ||
| assertFalse(lastCommittedConfiguration.getNodeIds().contains(disconnect1.getId())); | ||
| assertThat(lastCommittedConfiguration + " should be all nodes", lastCommittedConfiguration.getNodeIds(), | ||
| equalTo(cluster.clusterNodes.stream().map(ClusterNode::getId).collect(Collectors.toSet()))); |
There was a problem hiding this comment.
test name is not correct anymore? it says "AndShrinksOnFailure"
There was a problem hiding this comment.
The name of the test that contains this line is testExpandsConfigurationWhenGrowingFromOneNodeToThreeButDoesNotShrink which seems right to me?
| cluster.stabilise(DEFAULT_CLUSTER_STATE_UPDATE_DELAY); | ||
| assertThat(CLUSTER_MASTER_NODES_FAILURE_TOLERANCE.get(leader.getLastAppliedClusterState().metaData().settings()), equalTo(1)); | ||
| assertTrue(CLUSTER_AUTO_SHRINK_VOTING_CONFIGURATION.get(leader.getLastAppliedClusterState().metaData().settings())); |
There was a problem hiding this comment.
maybe also update the test method name to say that it only shrinks back to 3?
There was a problem hiding this comment.
Ok I added BackToThree.
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we allow the user to set the minimum size of a voting configuration. On
reflection we would rather this was simply '3' where possible, and we can use
the retirement API to control the removal of nodes more explicitly.
This change replaces the old reconfigurator setting with a new one,
cluster.auto_shrink_voting_configuration, which determines whetherElasticsearch should automatically remove nodes from the voting configuration
or not.