HLRC: Adding Update datafeed API #34882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra |
|
Pinging @elastic/ml-core |
98 tasks
| @@ -209,6 +210,19 @@ static Request putDatafeed(PutDatafeedRequest putDatafeedRequest) throws IOExcep | |||
| return request; | |||
| } | |||
|
|
|||
| static Request updateDatafeed(UpdateDatafeedRequest updateDatafeedRequest) throws IOException { | |||
| String endpoint = new EndpointBuilder() | |||
| .addPathPart("").addPathPartAsIs("_xpack") | |||
There was a problem hiding this comment.
The first empty part seems redundant
There was a problem hiding this comment.
definitely :D copy paste error
| @@ -494,6 +495,46 @@ public void putDatafeedAsync(PutDatafeedRequest request, RequestOptions options, | |||
| Collections.emptySet()); | |||
| } | |||
|
|
|||
| /** | |||
| * Updated a Machine Learning Datafeed | |||
There was a problem hiding this comment.
typo: Updated -> Updates
| import java.util.Objects; | ||
|
|
||
| /** | ||
| * Updates a {@link org.elasticsearch.client.ml.datafeed.DatafeedConfig} with the passed {@link DatafeedUpdate} |
There was a problem hiding this comment.
This comment implies this class is the action. Reword to suit it is a request?
| machineLearningClient::updateDatafeed, | ||
| machineLearningClient::updateDatafeedAsync); | ||
|
|
||
| DatafeedConfig updatedDatafeed= response.getResponse(); |
There was a problem hiding this comment.
nit: missing space before equals
| <1> The updated configuration of the {ml} datafeed | ||
|
|
||
| [id="{upid}-{api}-config"] | ||
| ==== Updated Datafeed Configuration |
There was a problem hiding this comment.
This title/section might be unnecessary. Check update-job documentation. We could have a similar structure here unless you dislike that one.
dimitris-athanasiou
approved these changes
Oct 26, 2018
| import java.util.Objects; | ||
|
|
||
| /** | ||
| * Requests an updates to a {@link org.elasticsearch.client.ml.datafeed.DatafeedConfig} with the passed {@link DatafeedUpdate} |
There was a problem hiding this comment.
nit: updates -> update
benwtrent
added a commit
that referenced
this pull request
Oct 26, 2018
* HLRC: Adding Update datafeed API * Addressing unused import * Adjusting docs and fixing minor comments * fixing comment
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
* HLRC: Adding Update datafeed API * Addressing unused import * Adjusting docs and fixing minor comments * fixing comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HLRC: ML Adds the Update Datafeed API
Relates to #29827