SQL: Verifier allows aliases aggregates for sorting #34773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-search-aggs |
Improve Verifier rule that prevented grouping, aliases inside aggregates to not be accepted for ordering. Close elastic#34607
matriv
approved these changes
Oct 24, 2018
| @@ -110,6 +118,11 @@ public void testGroupByOrderByNonGrouped() { | |||
| verify("SELECT MAX(int) FROM test GROUP BY text ORDER BY bool")); | |||
| } | |||
|
|
|||
| public void testGroupByOrderByAliasedInSelectAllowed() { | |||
| LogicalPlan lp = accepted("SELECT text t FROM test GROUP BY text ORDER BY t"); | |||
There was a problem hiding this comment.
You don't group by the alias t but you use text, was that the intention? Because here you use the alias: https://github.com/elastic/elasticsearch/pull/34773/files#diff-3d7c2dc164e7f948316c325f88c12a3fR39
There was a problem hiding this comment.
The verifier query is correct, the sql isn't (it's a typo). Fixing this in a follow-up commit.
costin
added a commit
that referenced
this pull request
Oct 24, 2018
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Improve Verifier rule that prevented grouping with aliases inside aggregates to not be accepted for ordering. Close #34607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Verifier rule that prevented grouping, aliases inside aggregates
to not be accepted for ordering.
Close #34607