SQL: Implement CONVERT, an alternative to CAST
#34660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CONVERT` works exactly like cast with slightly different syntax: `CONVERT(<value>, <data_type)` as opposed to `CAST(<value> AS <data_type>)` Moreover it support format of the MS-SQL data types `SQL_<type>`, e.g.: `SQL_INTEGER` Closes: elastic#34513
|
Pinging @elastic/es-search-aggs |
|
@costin @astefan Instead of In this case, the user won't get a |
|
Definitely UNSUPPORTED from usability point of view. It is not an invalid data type, but rather a valid one we do not support yet. |
costin
approved these changes
Oct 21, 2018
| @@ -44,12 +45,63 @@ | |||
| DATE( JDBCType.TIMESTAMP, Timestamp.class, Long.BYTES, 24, 24); | |||
| // @formatter:on | |||
|
|
|||
| public static final String MSSQL_DATATYPE_PREFIX = "SQL_"; | |||
There was a problem hiding this comment.
It's not so much MSSQL as ODBC spec.
There was a problem hiding this comment.
Sure, replaced all MSSQL with ODBC.
astefan
approved these changes
Oct 21, 2018
| ; | ||
|
|
||
|
|
||
| conversionStringToIntConvertESDataType |
There was a problem hiding this comment.
I would put this example first and the odbc one second, in order of familiarity/usage?
|
retest this please |
1 similar comment
|
retest this please |
|
Try merging master again - hopefully it fixes the external failure. |
matriv
pushed a commit
that referenced
this pull request
Oct 23, 2018
`CONVERT` works exactly like cast with slightly different syntax: `CONVERT(<value>, <data_type)` as opposed to `CAST(<value> AS <data_type>)` Moreover it support format of the MS-SQL data types `SQL_<type>`, e.g.: `SQL_INTEGER` Closes: #34513
|
Backported to |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Oct 23, 2018
* master: (24 commits) ingest: better support for conditionals with simulate?verbose (elastic#34155) [Rollup] Job deletion should be invoked on the allocated task (elastic#34574) [DOCS] .Security index is never auto created (elastic#34589) CCR: Requires soft-deletes on the follower (elastic#34725) re-enable bwc tests (elastic#34743) Empty GetAliases authorization fix (elastic#34444) INGEST: Document Processor Conditional (elastic#33388) [CCR] Add total fetch time leader stat (elastic#34577) SQL: Support pattern against compatible indices (elastic#34718) [CCR] Auto follow pattern APIs adjustments (elastic#34518) [Test] Remove dead code from ExceptionSerializationTests (elastic#34713) A small typo in migration-assistance doc (elastic#34704) ingest: processor stats (elastic#34724) SQL: Implement IN(value1, value2, ...) expression. (elastic#34581) Tests: Add checks to GeoDistanceQueryBuilderTests (elastic#34273) INGEST: Rename Pipeline Processor Param. (elastic#34733) Core: Move IndexNameExpressionResolver to java time (elastic#34507) [DOCS] Force Merge: clarify execution and storage requirements (elastic#33882) TESTING.asciidoc fix examples using forbidden annotation (elastic#34515) SQL: Implement `CONVERT`, an alternative to `CAST` (elastic#34660) ...
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
`CONVERT` works exactly like cast with slightly different syntax: `CONVERT(<value>, <data_type)` as opposed to `CAST(<value> AS <data_type>)` Moreover it support format of the MS-SQL data types `SQL_<type>`, e.g.: `SQL_INTEGER` Closes: #34513
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONVERTworks exactly like cast with slightly different syntax:CONVERT(<value>, <data_type)as opposed toCAST(<value> AS <data_type>)Moreover it support format of the MS-SQL data types
SQL_<type>,e.g.:
SQL_INTEGERCloses: #34513