Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SAML Redirect Signing test #34562

Merged
merged 1 commit into from
Oct 19, 2018
Merged

Conversation

jkakavas
Copy link
Member

Add a test to verify that we generate correct signatures for our
SAML2 Single Logout requests when using the redirect binding.

Add a test to verify that we generate correct signatures for our
SAML2 Single Logout requests when using the redirect binding.
@jkakavas jkakavas added >test Issues or PRs that are addressing/adding tests v7.0.0 :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v6.5.0 labels Oct 17, 2018
@jkakavas jkakavas requested a review from tvernum October 17, 2018 16:42
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

Copy link
Contributor

@tvernum tvernum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jkakavas jkakavas merged commit 59033e0 into elastic:master Oct 19, 2018
jkakavas added a commit that referenced this pull request Oct 19, 2018
Add a test to verify that we generate correct signatures for our
SAML2 Single Logout requests when using the redirect binding.
@jkakavas jkakavas deleted the add-samlauthnsig-test branch October 19, 2018 11:12
kcm pushed a commit that referenced this pull request Oct 30, 2018
Add a test to verify that we generate correct signatures for our
SAML2 Single Logout requests when using the redirect binding.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) >test Issues or PRs that are addressing/adding tests v6.5.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants