HLRC - add support for source exists API #34519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra |
|
jenkins test this |
4 similar comments
|
jenkins test this |
|
jenkins test this |
|
jenkins test this |
|
jenkins test this |
markharwood
force-pushed
the
fix/27205SourceExistsv2
branch
from
d0e640a to
ae8d013
Compare
hub-cap
approved these changes
Oct 19, 2018
markharwood
force-pushed
the
fix/27205SourceExistsv2
branch
from
ae8d013 to
5a780f5
Compare
|
@hub-cap is this addition to the "exists" page OK? I suspect this |
|
as per the docs youve linked, it should just have a little blurb in the exists doc, just a small section added to it would do. just fyi, the link is actually broken, it looks like there is an extra letter L in _exists in your javadoc, ill mark it on the review, as well. |
hub-cap
reviewed
Oct 25, 2018
| @@ -725,6 +725,32 @@ public final void existsAsync(GetRequest getRequest, RequestOptions options, Act | |||
| emptySet()); | |||
| } | |||
|
|
|||
| /** | |||
| * Checks for the existence of a document with a _source field. Returns true if it exists, false otherwise. | |||
| * See <a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-get.html#_sourcel">Source exists API | |||
hub-cap
reviewed
Oct 25, 2018
|
|
||
| /** | ||
| * Asynchronously checks for the existence of a document with a _source field. Returns true if it exists, false otherwise. | ||
| * See <a href="https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-get.html#_sourcel">Source exists API |
API re-uses the GetRequest object (following the precedent set by the plain “exists” api). Relates to elastic#33686
markharwood
force-pushed
the
fix/27205SourceExistsv2
branch
from
5a780f5 to
bb6da03
Compare
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Oct 26, 2018
* 'master' of github.com:elastic/elasticsearch: Fix line length for org.elasticsearch.common.* files (elastic#34888) [ML] Extract common native process base class (elastic#34856) Refactor children aggregator into a generic ParentJoinAggregator (elastic#34845) [Style] Fix line lengths in action.admin.indices (elastic#34890) HLRC - add support for source exists API (elastic#34519) [CCR] Retry when no index shard stats can be found (elastic#34852) [Docs] audit logfile structured format (elastic#34584) [Test] Fix FullClusterRestartIT.testShrink() with copy_settings param (elastic#34853) Fix LineLength Check Suppressions: index.fielddata (elastic#34891) TEST: Stablize Minio Free Port Search (elastic#34894) Delete flaky SettingsBasedHostProviderIT test (elastic#34813) [ML] Include message in field_stats for text log files (elastic#34861) [TEST] HLRC: Expand failure messages in API checks (elastic#34838) Lowercase static final DeprecationLogger instance names (elastic#34887)
jasontedor
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Oct 26, 2018
* master: Introduce cross-cluster replication API docs (elastic#34726) Responses can use Writeable.Reader interface (elastic#34655) SQL: Provide null-safe scripts for Not and Neg (elastic#34877) Fix put/resume follow request parsing (elastic#34913) Fix line length for org.elasticsearch.common.* files (elastic#34888) [ML] Extract common native process base class (elastic#34856) Refactor children aggregator into a generic ParentJoinAggregator (elastic#34845) [Style] Fix line lengths in action.admin.indices (elastic#34890) HLRC - add support for source exists API (elastic#34519)
markharwood
added a commit
to markharwood/elasticsearch
that referenced
this pull request
Oct 29, 2018
HLRC - add support for source exists API API re-uses the GetRequest object (following the precedent set by the plain “exists” api).
markharwood
added a commit
that referenced
this pull request
Oct 29, 2018
HLRC - add support for source exists API API re-uses the GetRequest object (following the precedent set by the plain “exists” api). Backport of #34519
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
HLRC - add support for source exists API API re-uses the GetRequest object (following the precedent set by the plain “exists” api). Relates to #27205
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API re-uses the GetRequest object (following the precedent set by the plain “exists” api).
Relates to #27205