Allowing {index}/_xpack/rollup/data to accept comma delimited list #34115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>bug
v7.0.0
:StorageEngine/Rollup
|
Pinging @elastic/es-search-aggs |
|
Jenkins, retest this please |
jimczi
requested changes
Sep 28, 2018
| --- | ||
| "Verify job caps by rollup index comma delimited list": | ||
|
|
||
| - do: |
There was a problem hiding this comment.
You'll need to add a skip section to not run this test on version that don't have the fix:
- skip:
version: " - 6.99.99"
reason: "comma delimited index support was fixed in 7.0"
After the backport to 6x we'll change the skip version to 6.4.99.
| @@ -27,7 +28,8 @@ public RestGetRollupIndexCapsAction(Settings settings, RestController controller | |||
| protected RestChannelConsumer prepareRequest(RestRequest restRequest, NodeClient client) { | |||
| String index = restRequest.param(INDEX.getPreferredName()); | |||
| IndicesOptions options = IndicesOptions.fromRequest(restRequest, IndicesOptions.STRICT_EXPAND_OPEN_FORBID_CLOSED); | |||
| GetRollupIndexCapsAction.Request request = new GetRollupIndexCapsAction.Request(new String[]{index}, options); | |||
| GetRollupIndexCapsAction.Request request = | |||
| new GetRollupIndexCapsAction.Request(Strings.commaDelimitedListToStringArray(index), options); | |||
There was a problem hiding this comment.
Can you use Strings.splitStringByCommaToArray, it should be equivalent but that's the function used by the other action when they parse the index param.
benwtrent
added a commit
that referenced
this pull request
Oct 2, 2018
…34115) * Allowing `{index}/_xpack/rollup/data` to accept comma delimited list * Address PR comments
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
…34115) * Allowing `{index}/_xpack/rollup/data` to accept comma delimited list * Address PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{index}/_xpack/rollup/data is supposed to be able to return given a comma delimited list of indices, there was a slight oversight on the REST facing side that caused index lookups to be the literal string and not an expanded list from the parameter.
I apologize if the labels are not correct, this is my first bug PR referencing a released version.