[DOCS] add comment to clarify cluster name resolution #34014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently fallback to local indices whenever a remote cluster is not found, as there may still be indices / aliases with the same name. Such behaviour is lenient but needs to be kept for backwards compatibility. Clarified that in the code so we don't forget.
javanna
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search-aggs |
martijnvg
reviewed
Sep 24, 2018
| @@ -242,6 +243,10 @@ static DiscoveryNode buildSeedNode(String clusterName, String address, boolean p | |||
| perClusterIndices.computeIfAbsent(clusterName, k -> new ArrayList<>()).add(indexName); | |||
| } | |||
| } else { | |||
| //Indices can be created with ":" in their names only up to 5.6, and still be there up to 6.last, but aliases may be | |||
There was a problem hiding this comment.
I think both alias and index names can have : in the name until 6.last? https://github.com/elastic/elasticsearch/blob/6.x/server/src/main/java/org/elasticsearch/cluster/metadata/MetaDataCreateIndexService.java#L170
This validation method is both used for alias and index names. From 6.0 we log a deprecation warning, but not fail it. From 7.0 we fail such index or alias nems
There was a problem hiding this comment.
you are right, I thought that we introduced index name validation for that earlier compared to aliases. I will update.
There was a problem hiding this comment.
I pushed an update, thanks for double checking this Martijn.
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Sep 25, 2018
We currently fallback to local indices whenever a remote cluster is not found, as there may still be indices / aliases with the same name. Such behaviour is lenient but needs to be kept for backwards compatibility. Clarified that in the code so we don't forget. Relates to elastic#26247
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
We currently fallback to local indices whenever a remote cluster is not found, as there may still be indices / aliases with the same name. Such behaviour is lenient but needs to be kept for backwards compatibility. Clarified that in the code so we don't forget. Relates to #26247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently fallback to local indices whenever a remote cluster is not found, as there may still be indices / aliases with the same name. Such behaviour is lenient but needs to be kept for backwards compatibility. Clarified that in the code so we don't forget.
Relates to #26247