[HLRC] Documentation examples cleanup #34009
Conversation
with `{index}/_search` (elastic#29468)
Scripts have been moved to their own context (elastic#32096)
|
Pinging @elastic/es-core-infra |
|
this may be outdated with recent changes, @nik9000 can you have a look please? |
|
I'm not following along with the types removal stuff super closely which is the bulk of this. @jtibshirani will probably know it better so I'm pinging her. @original-brownbear is responsible for the ctx thing and probably should look at this too. |
|
The changes around |
|
I've merged master to fix the merge conflict that I introduced. I tested it locally. I've reached out to @original-brownbear to talk about |
* Replace deprecated field `code` with `source` for stored scripts (#25127) * Replace examples using the deprecated endpoint `{index}/{type}/_search` with `{index}/_search` (#29468) * Use a system property to avoid deprecation warnings after the Update Scripts have been moved to their own context (#32096)
|
All merged now! Thanks again @lipsill! |
|
Thanks everybody! Thanks @nik9000 ! |
* Replace deprecated field `code` with `source` for stored scripts (#25127) * Replace examples using the deprecated endpoint `{index}/{type}/_search` with `{index}/_search` (#29468) * Use a system property to avoid deprecation warnings after the Update Scripts have been moved to their own context (#32096)
While digging into something else I noticed that there are several WARN messages in the high-level REST client integration tests. And most of them are caused by examples in the documentation that use deprecated functionality (i.e. specifying
typein_searchrequests). While the high level rest client should support the 'deprecated' functionality, I think that the client's documentation must not cover such examples.This PR modifies the examples so that there are no deprecation warnings. The changes are grouped in separate commits, so it is easy to pick and choose the changes that should be adopted.