Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkstyle: Package declarations #33784

Merged
merged 1 commit into from
Sep 18, 2018

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Sep 17, 2018

Make sure that all java files have a package declaration and that all of
the package declarations line up with the directory structure. This
would have caught the bug that I caused in
190ea9a and fixed in
b6d68bd.

Make sure that all java files have a package declaration and that all of
the package declarations line up with the directory structure. This
would have caught the bug that I caused in
190ea9a and fixed in
b6d68bd.
@nik9000 nik9000 added review :Delivery/Build Build or test infrastructure v7.0.0 v6.5.0 labels Sep 17, 2018
@nik9000 nik9000 requested a review from colings86 September 17, 2018 20:08
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@nik9000
Copy link
Member Author

nik9000 commented Sep 17, 2018

The extra checkstyle check doesn't seem to add any time to the build.

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nik9000 nik9000 merged commit bc12a94 into elastic:master Sep 18, 2018
nik9000 added a commit that referenced this pull request Sep 18, 2018
Make sure that all java files have a package declaration and that all of
the package declarations line up with the directory structure. This
would have caught the bug that I caused in
190ea9a and fixed in
b6d68bd.
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v6.5.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants