HLRC: ML PUT Calendar #33362
HLRC: ML PUT Calendar #33362
Conversation
|
Pinging @elastic/es-core-infra |
|
Pinging @elastic/ml-core |
davidkyle
force-pushed
the
hlrc-put-calendar
branch
from
696b67e
to
50ba8aa
Compare
|
retest this please |
| */ | ||
| public Calendar(String id, List<String> jobIds, @Nullable String description) { | ||
| this.id = Objects.requireNonNull(id, ID.getPreferredName() + " must not be null"); | ||
| this.jobIds = Objects.requireNonNull(jobIds, JOB_IDS.getPreferredName() + " must not be null"); |
There was a problem hiding this comment.
I would think that the this.jobIds should be made immutable here, or at least create a new ArrayList from the passed in list.
| return true; | ||
| } | ||
|
|
||
| if (!(obj instanceof Calendar)) { |
There was a problem hiding this comment.
For consistency, please use obj == null || getClass() != obj.getClass() for equality check.
| return true; | ||
| } | ||
|
|
||
| if (!(obj instanceof ScheduledEvent)) { |
There was a problem hiding this comment.
See comment on the Calender#equals method.
|
|
||
| @Override | ||
| protected boolean supportsUnknownFields() { | ||
| return false; |
There was a problem hiding this comment.
This should be true. This is just a wrapper for the Calendar class whose parser ignores unknown fields.
|
|
||
| @Override | ||
| protected boolean supportsUnknownFields() { | ||
| return false; |
|
|
||
| @Override | ||
| protected boolean supportsUnknownFields() { | ||
| return false; |
| <1> Create a request with the given Calendar | ||
|
|
||
|
|
||
| [[java-rest-high-snapshot-ml-put-calendar-response]] |
There was a problem hiding this comment.
Why is this java-rest-high-snapshot... ?
There was a problem hiding this comment.
Good catch. I based this on another doc which in turn must have been copied form the snapshot restore API. There were a a number of ML docs that had the same mis-naming
davidkyle
force-pushed
the
hlrc-put-calendar
branch
5 times, most recently
from
a3d49b5
to
c8ff4ec
Compare
davidkyle
force-pushed
the
hlrc-put-calendar
branch
from
c8ff4ec
to
647b817
Compare
* master: Add script to cache dependencies (elastic#33726) [DOCS] Moves security reference to docs folder (elastic#33643) Cleanup assertions in global checkpoint listeners (elastic#33722) [CCR] Move ccr tests in core module back to ccr module (elastic#33711) HLRC: ML PUT Calendar (elastic#33362) [Tests] Fix randomization in StringTermsIT (elastic#33678) Pin TLS1.2 in SSLConfigurationReloaderTests
For #29827