Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLRC: request/response homogeneity and JavaDoc improvements #33133

Merged

Conversation

benwtrent
Copy link
Member

Brings response/requests for ML HLRC into a more homogeneous format when it comes to Docs and immutability.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent benwtrent merged commit 52cf57e into elastic:master Aug 24, 2018
@benwtrent benwtrent deleted the feature/hlrc-ml-req-resp-refactor branch August 24, 2018 18:18
dnhatn added a commit that referenced this pull request Aug 26, 2018
* master:
  Add proxy support to RemoteClusterConnection (#33062)
  TEST: Skip assertSeqNos for closed shards (#33130)
  TEST: resync operation on replica should acquire shard permit (#33103)
  Switch remaining x-pack tests to new style Requests (#33108)
  Switch remaining tests to new style Requests (#33109)
  Switch remaining ml tests to new style Requests (#33107)
  Build: Line up IDE detection logic
  Security index expands to a single replica (#33131)
  HLRC: request/response homogeneity and JavaDoc improvements (#33133)
  Checkstyle!
  [Test] Fix sporadic failure in MembershipActionTests
  Revert "Do NOT allow termvectors on nested fields (#32728)"
  [Rollup] Move toAggCap() methods out of rollup config objects (#32583)
  Fix race condition in scheduler engine test
dnhatn added a commit that referenced this pull request Aug 26, 2018
* 6.x:
  Allow engine to recover from translog upto a seqno (#33032)
  TEST: Skip assertSeqNos for closed shards (#33130)
  TEST: resync operation on replica should acquire shard permit (#33103)
  Add proxy support to RemoteClusterConnection (#33062)
  Build: Line up IDE detection logic
  Security index expands to a single replica (#33131)
  Suppress more tests
  HLRC: request/response homogeneity and JavaDoc improvements (#33133)
  [Rollup] Move toAggCap() methods out of rollup config objects (#32583)
  Muted all these tests due to #33128
  Fix race condition in scheduler engine test
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@benwtrent benwtrent removed the :ml Machine learning label Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants