Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Fix convert error tests to use fixed value #32415

Merged
merged 3 commits into from
Jul 30, 2018
Merged

Tests: Fix convert error tests to use fixed value #32415

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0cf7737
Tests: Fix convert error tests to use fixed value
rjernst Jul 26, 2018
e8893f8
Merge remote-tracking branch 'elastic/master' into pr/32415
jasontedor Jul 27, 2018
82b9da5
Remove added awaits fix
jasontedor Jul 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...es/ingest-common/src/test/java/org/elasticsearch/ingest/common/ConvertProcessorTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,9 @@ public void testConvertIntLeadingZero() throws Exception {
assertThat(ingestDocument.getFieldValue(fieldName, Integer.class), equalTo(10));
}

@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/32370")
public void testConvertIntHexError() {
IngestDocument ingestDocument = RandomDocumentPicks.randomIngestDocument(random());
String value = "0x" + randomAlphaOfLengthBetween(1, 10);
String value = "0xnotanumber";
String fieldName = RandomDocumentPicks.addRandomField(random(), ingestDocument, value);
Processor processor = new ConvertProcessor(randomAlphaOfLength(10), fieldName, fieldName, Type.INTEGER, false);
IllegalArgumentException e = expectThrows(IllegalArgumentException.class, () -> processor.execute(ingestDocument));
Expand Down Expand Up @@ -138,10 +137,9 @@ public void testConvertLongLeadingZero() throws Exception {
assertThat(ingestDocument.getFieldValue(fieldName, Long.class), equalTo(10L));
}

@AwaitsFix( bugUrl = "https://github.com/elastic/elasticsearch/issues/32370")
public void testConvertLongHexError() {
IngestDocument ingestDocument = RandomDocumentPicks.randomIngestDocument(random());
String value = "0x" + randomAlphaOfLengthBetween(1, 10);
String value = "0xnotanumber";
String fieldName = RandomDocumentPicks.addRandomField(random(), ingestDocument, value);
Processor processor = new ConvertProcessor(randomAlphaOfLength(10), fieldName, fieldName, Type.LONG, false);
IllegalArgumentException e = expectThrows(IllegalArgumentException.class, () -> processor.execute(ingestDocument));
Expand Down