Painless: Move and Rename Several Methods in the lookup package #32105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra |
rjernst
approved these changes
Jul 16, 2018
|
|
||
| public final class PainlessLookupUtility { | ||
|
|
||
| // The following terminology is used for variable names throughout the lookup package: |
There was a problem hiding this comment.
Please move this to a javadoc on the class, and add a general description as to why this class exists.
| // Under ambiguous circumstances most variable names are prefixed with asm, java, or painless. | ||
| // If the variable name is the same for asm, java, and painless, no prefix is used. | ||
|
|
||
| public static Class<?> javaObjectTypeToPainlessDefType(Class<?> javaType) { |
There was a problem hiding this comment.
a brief one liner would be nice on most of these methods, especially since at a glance, you would think this would always return def.class, but an explanation of the array case necessary would be nice. These could be in a followup since I know they are just moving here and were undocumented in their previous location.
There was a problem hiding this comment.
Yes, once I'm done with the functional changes I'll go back and ensure everything is documented.
|
@rjernst Thanks for the review! Will commit once CI completes. |
|
@elasticmachine test this please |
jdconrad
added a commit
that referenced
this pull request
Jul 16, 2018
martijnvg
added a commit
that referenced
this pull request
Jul 17, 2018
* es/6.x: Scripting: Remove dead code from painless module (#32064) (#32104) Painless: Move and Rename Several Methods in the lookup package (#32105) Bypass highlight query terms extraction on empty fields (#32090) Core: Backport java time date formatters (#31997) Switch non-x-pack to new style requests (#32106) SQL: allow LEFT and RIGHT as function names (#32066) Painless: Separate PainlessLookup into PainlessLookup and PainlessLookupBuilder (#32054) [test] turn on host io cache for opensuse (#32053) DOCS: put LIMIT 10 to the SQL query (#32065)
martijnvg
added a commit
that referenced
this pull request
Jul 17, 2018
* es/master: Add Index UUID to `/_stats` Response (#31871) Painless: Move and Rename Several Methods in the lookup package (#32105) Bypass highlight query terms extraction on empty fields (#32090) Switch non-x-pack to new style requests (#32106) [Rollup] Add new capabilities endpoint for concrete rollup indices (#30401) Revert "[test] disable packaging tests for suse boxes" SQL: allow LEFT and RIGHT as function names (#32066) DOCS: put LIMIT 10 to the SQL query (#32065) [test] turn on host io cache for opensuse (#32053) Tweaked Elasticsearch Service links for SEO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mechanical change. Moves several shared static methods into a new PainlessLookupUtility class. These are used by both PainlessLookupBuilder and PainlessLookup along with several of the node classes for conversion between type names and types and java classes to painless classes.