Painless: Refactor Lookup into Multiple Classes #32017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PainlessLookupBuilder.
jdconrad
added
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra |
|
@elasticmachine test this please |
|
Going to break this into smaller pieces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't as large as it seems as a lot of code is just moved into new classes. This splits PainlessLookup into PainlessLookup, PainlessLookupBuilder, and PainlessLookupUtility. Utility contains numerous shared static methods for conversion between painless types/names and java types/names. PainlessLookupBuilder takes all the code required to create a PainlessLookup and separates it from PainlessLookup for easier maintainability moving forward. Other changes are related to these.
Also includes some name changes from struct to class that were overlooked in the previous refactor.