Check timeZone argument in AbstractSqlQueryRequest #31822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
reviewed
Jul 5, 2018
There was a problem hiding this comment.
Great catch @hanbj, makes sense to me. This also shows we are lacking a unit test for this method. Could you add one to SqlQueryRequestTests that checks that the right the exception is thrown when this setter is called (expectThrows() is a good helper method for that).
|
Pinging @elastic/es-search-aggs |
cbuescher
changed the title
cbuescher
requested changes
Jul 5, 2018
| @@ -110,4 +112,11 @@ protected SqlQueryRequest mutateInstance(SqlQueryRequest instance) { | |||
| mutator.accept(newRequest); | |||
| return newRequest; | |||
| } | |||
|
|
|||
| @Test | |||
| protected void testTimeZone() { | |||
There was a problem hiding this comment.
Thanks. Could you make this method public and remove the annotation please? We don't use the "@test" annotation in our tests, although I know it is common elsewhere, but it will fail our code style check. Also, could you rename the test method to something making clear this tests only the exception, e.g. testTimeZoneNullException.
| @Test | ||
| protected void testTimeZone() { | ||
| final SqlQueryRequest sqlQueryRequest = createTestInstance(); | ||
| IllegalArgumentException e = expectThrows(IllegalArgumentException.class, () -> sqlQueryRequest.timeZone((TimeZone)null)); |
There was a problem hiding this comment.
I think the cast can be removed, there is only one method.
|
@cbuescher Thank you for your guidance. |
|
@elasticmachine test this please |
|
@elasticmachien test this please |
cbuescher
pushed a commit
that referenced
this pull request
Jul 6, 2018
A value of `null` will throw an IAE.
dnhatn
added a commit
that referenced
this pull request
Jul 7, 2018
* 6.x: [ML] Fix master node deadlock during ML daily maintenance (#31836) Build: Switch integ-test-zip to OSS-only (#31866) Build: Fix detection of Eclipse Compiler Server (#31838) SQL: Remove restriction for single column grouping (#31818) Docs: Inconsistency between description and example (#31858) Fix and reenable TribeIntegrationTests QA: build improvements related to SQL projects (#31862) muted test [Docs] Add clarification to analysis example (#31826) Check timeZone() argument in AbstractSqlQueryRequest (#31822) Remove obsolete parameters from analyze rest spec (#31795) SQL: Fix incorrect HAVING equality (#31820) Smaller aesthetic fixes to InternalTestCluster (#31831) [Docs] Clarify accepted sort case (#31605) Do not return all indices if a specific alias is requested via get aliases api. (#29538) [Docs] Fix wrong link in Korean analyzer docs (#31815) Fix profiling of ordered terms aggs (#31814) Fix handling of points_only with term strategy in geo_shape (#31766) Docs: Explain _bulk?refresh shard targeting REST high-level client: add get index API (#31703)
dnhatn
added a commit
that referenced
this pull request
Jul 7, 2018
* master: [ML] Fix master node deadlock during ML daily maintenance (#31836) Build: Switch integ-test-zip to OSS-only (#31866) SQL: Remove restriction for single column grouping (#31818) Build: Fix detection of Eclipse Compiler Server (#31838) Docs: Inconsistency between description and example (#31858) Re-enable bwc tests now that #29538 has been backported and 6.x intake build succeeded. QA: build improvements related to SQL projects (#31862) [Docs] Add clarification to analysis example (#31826) Check timeZone() argument in AbstractSqlQueryRequest (#31822) SQL: Fix incorrect HAVING equality (#31820) Smaller aesthetic fixes to InternalTestCluster (#31831) [Docs] Clarify accepted sort case (#31605) Temporarily disable bwc test in order to backport #29538 Remove obsolete parameters from analyze rest spec (#31795) [Docs] Fix wrong link in Korean analyzer docs (#31815) Fix profiling of ordered terms aggs (#31814) Properly mute test involving JDK11 closes #31739 Do not return all indices if a specific alias is requested via get aliases api. (#29538) Get snapshot rest client cleanups (#31740) Docs: Explain _bulk?refresh shard targeting Fix handling of points_only with term strategy in geo_shape (#31766)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's not to judge whether timeZone is null.