Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up some double semicolons #31687

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Clean up some double semicolons #31687

merged 1 commit into from
Jul 2, 2018

Conversation

cbuescher
Copy link
Member

Non-issue, just sed-ed some annoying double-semicolons.

@jasontedor
Copy link
Member

Thanks for cleaning these up @cbuescher. Interestingly, if I am reading the grammar correctly (see JLS 7.5.1 and JLS 19), it appears that some of the examples here (the double semi-colons on import statements) should actually be compile-time errors. This implies that javac is not following the specification.

@cbuescher cbuescher merged commit 31aabe4 into elastic:master Jul 2, 2018
@nik9000
Copy link
Member

nik9000 commented Jul 2, 2018

Thanks for cleaning these up @cbuescher. Interestingly, if I am reading the grammar correctly (see JLS 7.5.1 and JLS 19), it appears that some of the examples here (the double semi-colons on import statements) should actually be compile-time errors. This implies that javac is not following the specification.

I remember having that problem before. I think Eclipse blew up on them for a little while and they closed the bug as "the spec says you can't have them".

dnhatn added a commit that referenced this pull request Jul 4, 2018
@dnhatn
Merge branch 'master' into ccr
f736205 
* master:
  [ML] Rate limit established model memory updates (#31768)
  [Docs] Correct default window_size (#31582)
  S3 fixture should report 404 on unknown bucket (#31782)
  Detach Transport from TransportService (#31727)
  [ML] Limit ML filter items to 10K (#31731)
  [ML] Return statistics about forecasts as part of the jobsstats and usage API (#31647)
  Fixture for Minio testing (#31688)
  [DOCS] Add missing get mappings docs to HLRC (#31765)
  [DOCS] Starting Elasticsearch (#31701)
  Painless: Complete Removal of Painless Type (#31699)
  Fix not waiting for Netty ThreadDeathWatcher in IT (#31758)
  Consolidate watcher setting update registration (#31762)
  Build: re-enabled bwc (#31769)
  ingest: Introduction of a bytes processor (#31733)
  Fix coerce validation_method in GeoBoundingBoxQueryBuilder (#31747)
  Add analyze API to high-level rest client (#31577)
  [DOCS] Typos
  DOC: Add examples to the SQL docs (#31633)
  Add support for AWS session tokens (#30414)
  Watcher: Reenable start/stop yaml tests (#31754)
  Implemented XContent serialisation for GetIndexResponse (#31675)
  JDBC: Fix stackoverflow on getObject and timestamp conversion (#31735)
  resolveHasher defaults to NOOP (#31723)
  Account for XContent overhead in in-flight breaker
  Split CircuitBreaker-related tests (#31659)
  Add write*Blob option to replace existing blob (#31729)
  Painless: Add Context Docs (#31190)
  Watcher: Fix chain input toXcontent serialization (#31721)
  Docs: Match the examples in the description (#31710)
  rest-high-level: added get cluster settings (#31706)
  [Docs] Correct typos (#31720)
  Clean up double semicolon code typos (#31687)
  [DOCS] Check for Windows and *nix file paths (#31648)
  [ML] Validate ML filter_id (#31535)
  Revert long lines
  Fix TransportChangePasswordActionTests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpountz jpountz jpountz approved these changes

@nik9000 nik9000 nik9000 approved these changes

Assignees
No one assigned
Labels
>non-issue v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cbuescher @jasontedor @nik9000 @jpountz @colings86