Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for field alias mappings. #31518

Merged
merged 5 commits into from
Jun 26, 2018
Merged

Add validation for field alias mappings. #31518

merged 5 commits into from
Jun 26, 2018
+498 −137

Commits on Jun 25, 2018

  1. Perform basic validation on the target of an alias.

    @jtibshirani
    jtibshirani committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    a5a66ff View commit details
    Browse the repository at this point in the history

  2. Pull out some validation logic into a separate class.

    @jtibshirani
    jtibshirani committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    0a3a4cd View commit details
    Browse the repository at this point in the history

  3. Validate that an alias and its target have the same nested scope.

    @jtibshirani
    jtibshirani committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    d2ebbbe View commit details
    Browse the repository at this point in the history

  4. Validate the uniqueness of field alias mappings.

    @jtibshirani
    jtibshirani committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    ec76559 View commit details
    Browse the repository at this point in the history

  5. Address code review feedback.

    @jtibshirani
    jtibshirani committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    f34f57d View commit details
    Browse the repository at this point in the history