Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Move rollup APIs to docs #31450

Merged
merged 4 commits into from
Aug 31, 2018
Merged

[DOCS] Move rollup APIs to docs #31450

merged 4 commits into from
Aug 31, 2018

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jun 20, 2018

Related to #30665

This PR moves the source files from x-pack/docs/en/rest-api/rollup to docs/reference/rollup

@lcawl lcawl added >docs General docs changes v7.0.0 :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data v6.4.0 v6.3.1 labels Jun 20, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@polyfractal
Copy link
Contributor

Hm, I think some things got lost in the transition over. The failure from CI reproduces locally (looks like it's trying to recreate the same job which already exists), and I see that there are errors related to the REST spec:

Failure at [reference/rollup/apis/get-job:29]: rest api [xpack.rollup.put_job] doesn't exist in the rest spec

I think we will have to move the REST spec and yaml tests over too? Or adjust the runner to look in multiple places for the spec?

@polyfractal
Copy link
Contributor

Ok, so the "already exists" job is because we cleanup the rollup state in XPackRestIT, and there's no equivalent in DocsClientYamlTestSuiteIT.

We can move over RollupRestTestStateCleaner and friends, but I'm not sure how that will affect things with the OSS doc tests.

I think Monitoring and ML will have similar issues.

@nik9000 thoughts?

@nik9000
Copy link
Member

nik9000 commented Jun 21, 2018

I'd look at moving RollupRestTestStateCleaner over to the test framework and then using it in the docs tests. That kind of thing is the price that we pay for running these integration tests I think.

@davidkyle davidkyle added v6.3.2 and removed v6.3.1 labels Jul 5, 2018
@polyfractal
Copy link
Contributor

@lcawl sorry, this totally fell off my radar. I'll take over the PR and get the test stuff fixed up first thing next week!

@lcawl lcawl added v6.4.1 and removed v6.4.0 labels Aug 23, 2018
@lcawl
Copy link
Contributor Author

lcawl commented Aug 30, 2018

@polyfractal I've disabled the failing tests for now to enable the files to move. Is it acceptable to debug the test failures in a new PR after the move?

@lcawl lcawl added the v6.5.0 label Aug 31, 2018
@lcawl lcawl merged commit cdeadfc into elastic:master Aug 31, 2018
@lcawl lcawl deleted the lcawley-move-rollup branch August 31, 2018 17:50
lcawl added a commit that referenced this pull request Aug 31, 2018
@lcawl
[DOCS] Move rollup APIs to docs (#31450)
79cc55d
@polyfractal
Copy link
Contributor

👍

lcawl added a commit that referenced this pull request Aug 31, 2018
@lcawl
[DOCS] Move rollup APIs to docs (#31450)
ebb547c
@lcawl lcawl added the v6.3.3 label Aug 31, 2018
@lcawl lcawl removed the v6.3.2 label Aug 31, 2018
@lcawl lcawl mentioned this pull request Aug 31, 2018
Closed
lcawl added a commit that referenced this pull request Aug 31, 2018
@lcawl
[DOCS] Move rollup APIs to docs (#31450)
e771da4
dnhatn added a commit that referenced this pull request Sep 1, 2018
@dnhatn
Merge branch 'master' into ccr
b935076 
* master:
  Mute test watcher usage stats output
  [Rollup] Fix FullClusterRestart test
  Adjust soft-deletes version after backport into 6.5
  completely drop `index.shard.check_on_startup: fix` for 7.0 (#33194)
  Fix AwaitsFix issue number
  Mute SmokeTestWatcherWithSecurityIT testsi
  drop `index.shard.check_on_startup: fix` (#32279)
  tracked at
  [DOCS] Moves ml folder from x-pack/docs to docs (#33248)
  [DOCS] Move rollup APIs to docs (#31450)
  [DOCS] Rename X-Pack Commands section (#33005)
  TEST: Disable soft-deletes in ParentChildTestCase
  Fixes SecurityIntegTestCase so it always adds at least one alias (#33296)
  Fix pom for build-tools (#33300)
  Lazy evaluate java9home (#33301)
  SQL: test coverage for JdbcResultSet (#32813)
  Work around to be able to generate eclipse projects (#33295)
  Highlight that index_phrases only works if no slop is used (#33303)
  Different handling for security specific errors in the CLI. Fix for #33230 (#33255)
  [ML] Refactor delimited file structure detection (#33233)
  SQL: Support multi-index format as table identifier (#33278)
  MINOR: Remove Dead Code from PathTrie (#33280)
  Enable forbiddenapis server java9 (#33245)
dnhatn added a commit that referenced this pull request Sep 1, 2018
@dnhatn
Merge branch '6.x' into ccr-6.x
a6312a5 
* 6.x:
  Mute test watcher usage stats output
  [Rollup] Fix FullClusterRestart test
  TEST: Disable soft-deletes in ParentChildTestCase
  TEST: Disable randomized soft-deletes settings
  Integrates soft-deletes into Elasticsearch (#33222)
  drop `index.shard.check_on_startup: fix` (#32279)
  Fix AwaitsFix issue number
  Mute SmokeTestWatcherWithSecurityIT testsi
  [DOCS] Moves ml folder from x-pack/docs to docs (#33248)
  TEST: mute more SmokeTestWatcherWithSecurityIT tests
  [DOCS] Move rollup APIs to docs (#31450)
  [DOCS] Rename X-Pack Commands section (#33005)
  Fixes SecurityIntegTestCase so it always adds at least one alias (#33296)
  TESTS: Fix Random Fail in MockTcpTransportTests (#33061) (#33307)
  MINOR: Remove Dead Code from PathTrie (#33280) (#33306)
  Fix pom for build-tools (#33300)
  Lazy evaluate java9home (#33301)
  SQL: test coverage for JdbcResultSet (#32813)
  Work around to be able to generate eclipse projects (#33295)
  Different handling for security specific errors in the CLI. Fix for #33230 (#33255)
  [ML] Refactor delimited file structure detection (#33233)
  SQL: Support multi-index format as table identifier (#33278)
  Enable forbiddenapis server java9 (#33245)
  [MUTE] SmokeTestWatcherWithSecurityIT flaky tests
  Add region ISO code to GeoIP Ingest plugin (#31669) (#33276)
  Don't be strict for 6.x
  Update serialization versions for custom IndexMetaData backport
  Replace IndexMetaData.Custom with Map-based custom metadata (#32749)
  Painless: Fix Bindings Bug (#33274)
  SQL: prevent duplicate generation for repeated aggs (#33252)
  TEST: Mute testMonitorClusterHealth
  Fix serialization of empty field capabilities response (#33263)
  Fix nested _source retrieval with includes/excludes (#33180)
  [DOCS] TLS file resources are reloadable (#33258)
  Watcher: Ensure TriggerEngine start replaces existing watches (#33157)
  Ignore module-info in jar hell checks (#33011)
  Fix docs build after #33241
  [DOC] Repository GCS ADC not supported (#33238)
  Upgrade to latest Gradle 4.10  (#32801)
  Fix/30904 cluster formation part2 (#32877)
  Move file-based discovery to core (#33241)
  HLRC: add client side RefreshPolicy (#33209)
  [Kerberos] Add unsupported languages for tests (#33253)
  Watcher: Reload properly on remote shard change (#33167)
  Fix classpath security checks for external tests. (#33066)
  [Rollup] Only allow aggregating on multiples of configured interval (#32052)
  Added deprecation warning for rescore in scroll queries (#33070)
  Apply settings filter to get cluster settings API (#33247)
  [Rollup] Re-factor Rollup Indexer into a generic indexer for re-usability   (#32743)
  HLRC: create base timed request class (#33216)
  HLRC: Use Optional in validation logic (#33104)
  Painless: Add Bindings (#33042)
jasontedor added a commit to martijnvg/elasticsearch that referenced this pull request Sep 2, 2018
@jasontedor
Merge branch 'master' into ccr_auto_follow
6907ce9 
* master: (64 commits)
  HLREST: add update by query API (elastic#32760)
  TEST: Increase timeout testFollowIndexAndCloseNode (elastic#33333)
  HLRC: ML Flush job (elastic#33187)
  HLRC: Adding ML Job stats (elastic#33183)
  LLREST: Drop deprecated methods (elastic#33223)
  Mute testSyncerOnClosingShard
  [DOCS] Moves machine learning APIs to docs folder (elastic#31118)
  Mute test watcher usage stats output
  [Rollup] Fix FullClusterRestart test
  Adjust soft-deletes version after backport into 6.5
  completely drop `index.shard.check_on_startup: fix` for 7.0 (elastic#33194)
  Fix AwaitsFix issue number
  Mute SmokeTestWatcherWithSecurityIT testsi
  drop `index.shard.check_on_startup: fix` (elastic#32279)
  tracked at
  [DOCS] Moves ml folder from x-pack/docs to docs (elastic#33248)
  [DOCS] Move rollup APIs to docs (elastic#31450)
  [DOCS] Rename X-Pack Commands section (elastic#33005)
  TEST: Disable soft-deletes in ParentChildTestCase
  Fixes SecurityIntegTestCase so it always adds at least one alias (elastic#33296)
  ...
jasontedor added a commit to debadair/elasticsearch that referenced this pull request Sep 2, 2018
@jasontedor
Merge branch 'master' into HEAD
0e3d6c5 
* master: (283 commits)
  HLREST: add update by query API (elastic#32760)
  TEST: Increase timeout testFollowIndexAndCloseNode (elastic#33333)
  HLRC: ML Flush job (elastic#33187)
  HLRC: Adding ML Job stats (elastic#33183)
  LLREST: Drop deprecated methods (elastic#33223)
  Mute testSyncerOnClosingShard
  [DOCS] Moves machine learning APIs to docs folder (elastic#31118)
  Mute test watcher usage stats output
  [Rollup] Fix FullClusterRestart test
  Adjust soft-deletes version after backport into 6.5
  completely drop `index.shard.check_on_startup: fix` for 7.0 (elastic#33194)
  Fix AwaitsFix issue number
  Mute SmokeTestWatcherWithSecurityIT testsi
  drop `index.shard.check_on_startup: fix` (elastic#32279)
  tracked at
  [DOCS] Moves ml folder from x-pack/docs to docs (elastic#33248)
  [DOCS] Move rollup APIs to docs (elastic#31450)
  [DOCS] Rename X-Pack Commands section (elastic#33005)
  TEST: Disable soft-deletes in ParentChildTestCase
  Fixes SecurityIntegTestCase so it always adds at least one alias (elastic#33296)
  ...
@lcawl lcawl mentioned this pull request Jan 28, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik9000 nik9000 Awaiting requested review from nik9000

@polyfractal polyfractal Awaiting requested review from polyfractal

Assignees
No one assigned
Labels
>docs General docs changes :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data v6.3.3 v6.4.1 v6.5.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lcawl @elasticmachine @polyfractal @nik9000 @colings86 @davidkyle