Docs: Add ccr to the cat thread pool doc test #31442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since elastic#31251, we use the default distribution to test docs. With this distribution, the cat thread-pool response will include the ccr thread-pool. This commit adjusts /_cat/thread_pool doc to include ccr. Relates elastic#31251
dnhatn
added
:Distributed Indexing/CCR
|
Pinging @elastic/es-distributed |
|
Pinging @elastic/es-docs |
|
The failed test is the one that I changed. The regex becomes longer, but I am not sure if it's the cause of the timeout. |
|
@elasticmachine test this please |
bleskes
approved these changes
Jun 20, 2018
|
I think the test was timeout because of the presence of the two |
|
Thanks @bleskes and @martijnvg for reviewing |
dnhatn
added a commit
that referenced
this pull request
Jun 21, 2018
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Aug 27, 2018
The fix proposed in elastic#31442 fails with the oss distro because the added 3dots does not match anything with the default oss while a 3dots expression requires matching at least one thread pool. This change adjusts the thread pool list so that it can match both the oss (without ccr) and default distro (with ccr).
dnhatn
added a commit
that referenced
this pull request
Aug 27, 2018
The fix proposed in #31442 fails with the oss distro because the added 3dots does not match anything with the default oss while a 3dots expression requires matching at least one thread pool. This change makes an ellipsis optional so the thread_pool list can match both the oss distro (without ccr) and default distro (with ccr). Relates #31442
dnhatn
added a commit
that referenced
this pull request
Aug 27, 2018
The fix proposed in #31442 fails with the oss distro because the added 3dots does not match anything with the default oss while a 3dots expression requires matching at least one thread pool. This change makes an ellipsis optional so the thread_pool list can match both the oss distro (without ccr) and default distro (with ccr). Relates #31442
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #31251, we use the default distribution to test docs. With this
distribution, the cat thread-pool response will include the ccr
thread-pool. This commit adjusts
/_cat/thread_pooldoc to include ccr.Relates #31251