Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we don't use a remote profile if cluster name matches #31331

Merged
merged 6 commits into from
Jun 17, 2018
Merged

Ensure we don't use a remote profile if cluster name matches #31331

merged 6 commits into from
Jun 17, 2018
+153 −11

Commits on Jun 14, 2018

  1. Ensure we don't use a remote profile if cluster name matches 

    If we are running into a race condition between a node being configured
to be a remote node for cross cluster search etc. and that node joining
the cluster we might connect to that node with a remote profile. If that
node now joins the cluster it connected to it as a CCS remote node we use
the wrong profile and can't use bulk connections etc. anymore. This change
uses the remote profile only if we connect to a node that has a different cluster
name than the local cluster. This is not a perfect fix for this situation but
is the safe option while potentially only loose a small optimization of using
less connections per node which is small anyways since we only connect to a
small set of nodes.

Closes elastic#29321
    @s1monw
    s1monw committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    f324650 View commit details
    Browse the repository at this point in the history

  2. fix test

    @s1monw
    s1monw committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    72812be View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into issues/29321

    @s1monw
    s1monw committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    e17aec2 View commit details
    Browse the repository at this point in the history

  4. fix nits

    @s1monw
    s1monw committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    f85b32e View commit details
    Browse the repository at this point in the history

  5. fix nits

    @s1monw
    s1monw committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    e40bdd8 View commit details
    Browse the repository at this point in the history

  6. add test and fix MockTcpTransport to maintain supported channels

    @s1monw
    s1monw committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    8fb8dd9 View commit details
    Browse the repository at this point in the history