SQL: Add basic support for geo point #31257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds basic support for geo point type. For now the geopoint is represented as a string and returned in the same format it was stored in the source.
imotov
added
>feature
:Analytics/Geo
|
Pinging @elastic/es-search-aggs |
nik9000
approved these changes
Jun 12, 2018
|
|
||
| cmd.execute(null, ActionListener.wrap(r -> { | ||
| assertEquals(19, r.columnCount()); | ||
| assertEquals(18, r.size()); | ||
| assertEquals(19, r.size()); |
There was a problem hiding this comment.
assertEquals(names.size, r.size());?
|
@nik9000 correct, just trying to keep PRs manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic support for geo point type. For now, the geopoint is
represented as a string and returned in the same format it was stored
in the source.
Relates to #29872