Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with finishing handshake in ssl driver #30580

Merged
merged 2 commits into from
May 15, 2018
Merged

Fix issue with finishing handshake in ssl driver #30580

merged 2 commits into from
May 15, 2018

Commits on May 14, 2018

  1. Fix issue with finishing handshake in ssl driver 

    This is fixing an issue that has come up in some builds. In some
scenarios I see an assertion failure that we are trying to move to
application mode when we are not in handshake mode. What I think is
happening is that we are in handshake mode and have received the
completed handshake message AND an application message. While reading in
handshake mode we switch to application mode. However, there is still
data to be consumed so we attempt to continue to read in handshake mode.
This leads to us attempting to move to application mode again throwing
an assertion.

This commit fixes this by immediatly exiting the handshake mode read
method if we are not longer in handshake mode. Additionally if we swap
modes during a read we attempt to read with the new mode to see if there
is data that needs to be handled.
    @Tim-Brooks
    Tim-Brooks committed May 14, 2018
    Configuration menu
    Copy the full SHA
    3201187 View commit details
    Browse the repository at this point in the history

  2. Use do-while

    @Tim-Brooks
    Tim-Brooks committed May 14, 2018
    Configuration menu
    Copy the full SHA
    64fe782 View commit details
    Browse the repository at this point in the history