Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mute failing test see #30456 #30458

Merged
merged 1 commit into from
May 8, 2018
Merged

Mute failing test see #30456 #30458

merged 1 commit into from
May 8, 2018

Conversation

alpar-t
Copy link
Contributor

@alpar-t alpar-t commented May 8, 2018 •
edited
Loading

Mute test due to #30456

@alpar-t alpar-t added the >test Issues or PRs that are addressing/adding tests label May 8, 2018
@alpar-t alpar-t requested a review from nik9000 May 8, 2018 13:51
nik9000
nik9000 approved these changes May 8, 2018
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For these things we usually just push the fix without a PR in an effort to get the build green.

We should also figure out why the CLA checker bot doesn't like you.

...ng-upgrade/src/test/java/org/elasticsearch/upgrades/UpgradeClusterClientYamlTestSuiteIT.java
@@ -29,6 +30,7 @@
import static org.hamcrest.Matchers.is;

@TimeoutSuite(millis = 5 * TimeUnits.MINUTE) // to account for slow as hell VMs
@LuceneTestCase.AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/30456")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually directly import AwaitsFix.

@colings86 colings86 added the :ml Machine learning label May 8, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@davidkyle
Copy link
Member

@atorok when you merge please backport this to 6.x as the tests also fail on that branch

@nik9000
Copy link
Member

nik9000 commented May 8, 2018

I wouldn't normally do this but I'm going to merge this myself rather than wait for @atorok to get to it in the morning because the build is pretty busted and I'd like to give us a chance to merge other things before ml folks can take a look at this.

I'm going to ignore all the checks too ignore all of the failures because the ci ones look like some kind of strange git issue and the CLA one is just out of date. I know that @atorok is ok CLA wise.

@nik9000 nik9000 merged commit 4b36ea7 into elastic:master May 8, 2018
nik9000 pushed a commit that referenced this pull request May 8, 2018
@alpar-t @nik9000
Mute ML upgrade test (#30458)
dd029c2 
It fails fairly frequently. Some ML expert will look soon.
dnhatn added a commit that referenced this pull request May 8, 2018
@dnhatn
Merge branch 'master' into ccr
5d99157 
* master:
  Mute ML upgrade test (#30458)
  Stop forking javac (#30462)
  Client: Deprecate many argument performRequest (#30315)
  Docs: Use task_id in examples of tasks (#30436)
  Security: Rename IndexLifecycleManager to SecurityIndexManager (#30442)
  [Docs] Fix typo in cardinality-aggregation.asciidoc (#30434)
  Avoid NPE in `more_like_this` when field has zero tokens (#30365)
  Build: Switch to building javadoc with html5 (#30440)
  Add a quick tour of the project to CONTRIBUTING (#30187)
  Reindex: Use request flavored methods (#30317)
  Silence SplitIndexIT.testSplitIndexPrimaryTerm test failure. (#30432)
  Auto-expand replicas when adding or removing nodes (#30423)
  Docs: fix changelog merge
  Fix line length violation in cache tests
  Add stricter geohash parsing (#30376)
  Add failing test for core cache deadlock
  [DOCS] convert forcemerge snippet
  Update forcemerge.asciidoc (#30113)
  Added zentity to the list of API extension plugins (#29143)
  Fix the search request default operation behavior doc (#29302) (#29405)
dnhatn added a commit that referenced this pull request May 8, 2018
@dnhatn
Merge branch '6.x' into ccr-6.x
a3340d6 
* 6.x:
  Client: Deprecate many argument performRequest (#30315)
  Mute ML upgrade test (#30458)
@jasontedor
Copy link
Member

@nik9000 @atorok Add .patch to the PR URL and notice that there is a typo in the commit email address.

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request May 9, 2018
@jasontedor
Merge remote-tracking branch 'elastic/master' into cache-deadlock
a3e152f 
* elastic/master:
  Mute ML upgrade test (elastic#30458)
  Stop forking javac (elastic#30462)
  Client: Deprecate many argument performRequest (elastic#30315)
  Docs: Use task_id in examples of tasks (elastic#30436)
  Security: Rename IndexLifecycleManager to SecurityIndexManager (elastic#30442)
@alpar-t
Copy link
Contributor Author

alpar-t commented May 9, 2018 •
edited
Loading

Thanks @nik9000! @davidkyle I checked and this is in 6.x as well so probably Nik did both.

@alpar-t alpar-t deleted the mute/30456 branch May 9, 2018 07:37
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request May 9, 2018
@jasontedor
Merge remote-tracking branch 'elastic/master' into no-copy-settings-f…
030a3e9 
…or-you

* elastic/master: (22 commits)
  Docs: Test examples that recreate lang analyzers  (elastic#29535)
  BulkProcessor to retry based on status code (elastic#29329)
  Add GET Repository High Level REST API (elastic#30362)
  add a comment explaining the need for RetryOnReplicaException on missing mappings
  Add `coordinating_only` node selector (elastic#30313)
  Stop forking groovyc (elastic#30471)
  Avoid setting connection request timeout (elastic#30384)
  Use date format in `date_range` mapping before fallback to default (elastic#29310)
  Watcher: Increase HttpClient parallel sent requests (elastic#30130)
  Mute ML upgrade test (elastic#30458)
  Stop forking javac (elastic#30462)
  Client: Deprecate many argument performRequest (elastic#30315)
  Docs: Use task_id in examples of tasks (elastic#30436)
  Security: Rename IndexLifecycleManager to SecurityIndexManager (elastic#30442)
  [Docs] Fix typo in cardinality-aggregation.asciidoc (elastic#30434)
  Avoid NPE in `more_like_this` when field has zero tokens (elastic#30365)
  Build: Switch to building javadoc with html5 (elastic#30440)
  Add a quick tour of the project to CONTRIBUTING (elastic#30187)
  Reindex: Use request flavored methods (elastic#30317)
  Silence SplitIndexIT.testSplitIndexPrimaryTerm test failure. (elastic#30432)
  ...
jtibshirani pushed a commit that referenced this pull request May 11, 2018
@alpar-t @jtibshirani
Mute ML upgrade test (#30458)
33e39fa 
It fails fairly frequently. Some ML expert will look soon.
@jtibshirani
Copy link
Contributor

Just cherry-picked this to 6.3, as we've just seen the same failures there: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.3+multijob-unix-compatibility/os=centos/54/console

ywelsch added a commit that referenced this pull request May 15, 2018
@ywelsch
Revert "Mute ML upgrade test (#30458)"
74fcfef 
This reverts commit 4b36ea7.
ywelsch added a commit that referenced this pull request May 15, 2018
@ywelsch
Revert "Mute ML upgrade test (#30458)"
af2b9dd 
This reverts commit 4b36ea7.
ywelsch added a commit that referenced this pull request May 15, 2018
@ywelsch
Revert "Mute ML upgrade test (#30458)"
d508500 
This reverts commit 33e39fa.
dnhatn added a commit that referenced this pull request May 15, 2018
@dnhatn
Merge branch '6.x' into ccr-6.x
981884a 
* 6.x:
  Revert "Silence IndexUpgradeIT test failures. (#30430)"
  [DOCS] Remove references to changelog and to highlights
  Revert "Mute ML upgrade test (#30458)"
  [ML] Fix BWC version for backport of #30125
  [Docs] Improve section detailing translog usage (#30573)
  [Tests] Relax allowed delta in extended_stats aggregation (#30569)
  Fail if reading from closed KeyStoreWrapper (#30394)
  [ML] Reverse engineer Grok patterns from categorization results (#30125)
  Derive max composite buffers from max content len
  Update build file due to doc file rename
  SQL: Extract SQL request and response classes (#30457)
  Remove the changelog (#30593)
  Revert "Add deprecation warning for default shards (#30587)"
  Silence IndexUpgradeIT test failures. (#30430)
  Add deprecation warning for default shards (#30587)
  [DOCS] Adds 6.4.0 release highlight pages
  [DOCS] Adds release highlight pages (#30590)
  Docs: Document how to rebuild analyzers (#30498)
  [DOCS] Fixes title capitalization in security content
  LLRest: Add equals and hashcode tests for Request (#30584)
  [DOCS] Fix realm setting names (#30499)
  [DOCS] Fix path info for various security files (#30502)
  Docs: document precision limitations of geo_bounding_box (#30540)
  Fix non existing javadocs link in RestClientTests
  Auto-expand replicas only after failing nodes (#30553)
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request May 15, 2018
@jasontedor
Merge remote-tracking branch 'elastic/master' into default-copy-setti…
48c4166 
…ngs-to-true

* elastic/master:
  [DOCS] Restores 7.0.0 release notes and highlights
  Remove assert statements from field caps documentation. (elastic#30601)
  Repository GCS plugin new client library (elastic#30168)
  HLRestClient: Follow-up for put index template api (elastic#30592)
  Unmute IndexUpgradeIT tests
  [DOCS] Remove references to changelog and to highlights
  Side-step pending deletes check (elastic#30571)
  [DOCS] Remove references to removed changelog
  Revert "Mute ML upgrade test (elastic#30458)"
  [ML] Adjust BWC version following backport of elastic#30125
  [Docs] Improve section detailing translog usage (elastic#30573)
  [Tests] Relax allowed delta in extended_stats aggregation (elastic#30569)
  [ML] Reverse engineer Grok patterns from categorization results (elastic#30125)
  Update build file due to doc file rename
  Remove the changelog (elastic#30593)
  Fix issue with finishing handshake in ssl driver (elastic#30580)
  Fail if reading from closed KeyStoreWrapper (elastic#30394)
  Silence IndexUpgradeIT test failures. (elastic#30430)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik9000 nik9000 nik9000 approved these changes

Assignees
No one assigned
Labels
:ml Machine learning >test Issues or PRs that are addressing/adding tests v6.4.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alpar-t @elasticmachine @davidkyle @nik9000 @jasontedor @jtibshirani @colings86