Tests: Ensure each test uses different watch ids

[spinscale]

Each test now has its own watch id that is being used.
This ensures there are no old history entries, which can potentially
lead to broken test assertions.

[jasontedor]

LGTM.

[jasontedor]

On second thought, I have a question.

[jasontedor]

Should this be in a Before so it's unique per test?

[spinscale]

I was under the impression, that it is unique per test with this.

public class MyTestCase extends ESTestCase {

    private String watchId = randomAlphaOfLength(20);

    public void testFoo() {
        logger.info("id {}", watchId);
    }

    public void testBar() {
        logger.info("id {}", watchId);
    }
}

results in

[2018-05-02T13:46:10,464][INFO ][o.e.t.MyTestCase         ] [testBar]: before test
[2018-05-02T13:46:10,960][INFO ][o.e.t.MyTestCase         ] id kXWMGSVERErlmIhKUbFd
[2018-05-02T13:46:11,182][INFO ][o.e.t.MyTestCase         ] [testBar]: after test
[2018-05-02T13:46:11,241][INFO ][o.e.t.MyTestCase         ] [testFoo]: before test
[2018-05-02T13:46:11,241][INFO ][o.e.t.MyTestCase         ] id WCGxKOTIEHxFSZIghhBy
[2018-05-02T13:46:11,242][INFO ][o.e.t.MyTestCase         ] [testFoo]: after test

[jasontedor]

Sorry, I am not sure why but my mind inserted a static into that field definition. That's clearly not there so of course what you have is fine.

[elasticmachine]

Pinging @elastic/es-core-infra