-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove setting copy settings on resize to false #30321
Conversation
As the copy_settings REST parameter and copySettings transport field was deprecated in 6.4.0 slated for removal in 8.0.0, this commit puts us farther down that path by: - defaulting copy settings to true - preventing settings copy settings to false
@jasontedor This process for removal is a little different than I envisaged. I had thought that we would:
The worry I have with the approach in this PR is that it puts the hard break in 7.0 since there is no way of not copying settings so to me it seems that its the same as just removing the parameter in 7.0? |
@colings86 I am following the plan that we outlined here: #28347 I am fine with changing the plan, but I think the place for that discussion is the source issue. |
@jasontedor I left a comment on #28347 with my comments from above so we can discuss. Sorry I didn't think about this and bring up the concern earlier |
Pinging @elastic/es-core-infra |
Superseded by #30404 |
As the copy_settings REST parameter and copySettings transport field was deprecated in 6.4.0 slated for removal in 8.0.0, this commit puts us farther down that path by:
Relates #28347, relates #30255