-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watcher: Configure HttpClient parallel sent requests #30130
Merged
spinscale
merged 12 commits into
elastic:master
from
spinscale:1840-watcher-httpclient-evict-idle-connections
May 9, 2018
Merged
Watcher: Configure HttpClient parallel sent requests #30130
spinscale
merged 12 commits into
elastic:master
from
spinscale:1840-watcher-httpclient-evict-idle-connections
May 9, 2018
Commits on Apr 25, 2018
-
Watcher: Configure HttpClient parallel sent requests
The HTTPClient used in watcher is based on the apache http client. The current client is using a lot of defaults - which are not always optimal. Two of those defaults are the maximum number of total connections and the maximum number of connections to a single route. If one of those limits is reached, the HTTPClient waits for a connection to be finished thus acting in a blocking fashion. In order to prevent this when many requests are being executed, we increase the limit of total connections as well as the connections per route (a route is basically an endpoint, which also contains proxy information, not containing an URL, just hosts). On top of that an additional option has been made configurable to evict long running connections, which can potentially be reused after some time. As this requires an additional background thread, this required some changes to ensure that the httpclient is closed properly. Also the timeout for this can be configured.
Configuration menu - View commit details
-
Copy full SHA for 767df42 - Browse repository at this point
Copy the full SHA 767df42View commit details
Commits on Apr 27, 2018
-
Configuration menu - View commit details
-
Copy full SHA for e66e558 - Browse repository at this point
Copy the full SHA e66e558View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c593ce - Browse repository at this point
Copy the full SHA 0c593ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 37f4a86 - Browse repository at this point
Copy the full SHA 37f4a86View commit details
Commits on May 2, 2018
-
Configuration menu - View commit details
-
Copy full SHA for aa37df2 - Browse repository at this point
Copy the full SHA aa37df2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94ee2f0 - Browse repository at this point
Copy the full SHA 94ee2f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 437e6fb - Browse repository at this point
Copy the full SHA 437e6fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69cbb95 - Browse repository at this point
Copy the full SHA 69cbb95View commit details
Commits on May 3, 2018
-
Configuration menu - View commit details
-
Copy full SHA for b33385f - Browse repository at this point
Copy the full SHA b33385fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a9443a - Browse repository at this point
Copy the full SHA 0a9443aView commit details -
Configuration menu - View commit details
-
Copy full SHA for bb3063f - Browse repository at this point
Copy the full SHA bb3063fView commit details
Commits on May 4, 2018
-
Configuration menu - View commit details
-
Copy full SHA for c742208 - Browse repository at this point
Copy the full SHA c742208View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.