Add periodic flush count to flush stats #29360
Conversation
Currently, a flush stats contains only the total flush which is the sum of manual flush (via API) and periodic flush (async triggered when the uncommitted translog size is exceeded the flush threshold). Sometimes, it's useful to know these two numbers independently. This commit tracks and returns a periodic flush count in a flush stats.
dnhatn
added
>enhancement
:Data Management/Stats
|
Pinging @elastic/es-core-infra |
| @@ -85,6 +96,7 @@ public TimeValue getTotalTime() { | |||
| public XContentBuilder toXContent(XContentBuilder builder, Params params) throws IOException { | |||
| builder.startObject(Fields.FLUSH); | |||
| builder.field(Fields.TOTAL, total); | |||
| builder.field(Fields.PERIODIC, periodic); | |||
There was a problem hiding this comment.
can we have a rest test that checks that this is there?
There was a problem hiding this comment.
@s1monw
I had a test but I could not verify the periodic value as the periodic flush is executed async. Do you have any suggestion for this? Or just check its presence (eg. 0 is ok)?
There was a problem hiding this comment.
I used the analogue of gt: { periodic: 0} when I did something similar.
There was a problem hiding this comment.
Thanks @DaveCTurner. Unfortunately, sometimes a period flush might still be executing (or just scheduled) and periodic is still 0.
There was a problem hiding this comment.
Apologies, I meant gte: { periodic: 0 }
There was a problem hiding this comment.
I will go this suggestion. Thanks @DaveCTurner and @s1monw.
|
@s1monw I've added a rest test. Can you please have another look? Thank you! |
|
Thanks @s1monw and @DaveCTurner. |
Currently, a flush stats contains only the total flush which is the sum of manual flush (via API) and periodic flush (async triggered when the uncommitted translog size is exceeded the flush threshold). Sometimes, it's useful to know these two numbers independently. This commit tracks and returns a periodic flush count in a flush stats.
Currently, a flush stats contains only the total flush which is the sum
of manual flush (via API) and periodic flush (async triggered when the
uncommitted translog size is exceeded the flush threshold). Sometimes,
it's useful to know these two numbers independently. This commit tracks
and returns the periodic flush count in a flush stats.
Relates #29125