Replace parameter unicodeSetFilter with unicode_set_filter #29215
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
Pinging @elastic/es-search-aggs |
|
@elastic/es-search-aggs thoughts on this? |
|
@romseygeek would you be able to pick up reviewing this PR? |
|
I think this looks good, @liketic would you be able to update this to the latest master and push again? |
|
Thanks @romseygeek , I updated the branch, please review again. |
|
@elasticmachine test this please |
|
Looks good, thanks @liketic. One more thing, could you update |
|
Thanks @liketic ! |
| @@ -35,14 +38,15 @@ | |||
| * <p>The {@code unicodeSetFilter} attribute can be used to provide the UniCodeSet for filtering.</p> | |||
| */ | |||
| public class IcuNormalizerTokenFilterFactory extends AbstractTokenFilterFactory implements MultiTermAwareComponent { | |||
|
|
|||
| private final static DeprecationLogger deprecationLogger = | |||
There was a problem hiding this comment.
@romseygeek this line is causing checkstyle violations
> Task :plugins:analysis-icu:checkstyleMain FAILED
[ant:checkstyle] [ERROR] /home/alpar/work/elastic/elasticsearch/plugins/analysis-icu/src/main/java/org/elasticsearch/index/analysis/IcuNormalizerTokenFilterFactory.java:41:19: 'static' modifier out of order with the JLS suggestions. [ModifierOrder]
I'm pushing a fix to master now. FYI
There was a problem hiding this comment.
Master was merged in a few days ago and the checkstyle rules last changed 4 weeks ago, yet the PR build passed.
There was a problem hiding this comment.
I opened #35207 to fix these
Depreate parameter unicodeSetFilter and replace it with unicode_set_filter for IcuFoldingTokenFilter.
Close #22823