Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate mapping.single_type setting on shrinked index #29202

Merged
merged 1 commit into from
Mar 22, 2018

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented Mar 22, 2018

The index.mapping.single_type setting is not propagated when shrinking an index created in 5.x.
This breaks search/get on the shrinked index because this setting is used to choose
whether _uid or _id field should be used as the primary key.
This commit fixes this bug by copying the setting in the shrinked index.

The index.mapping.single_type setting is not propagated when shrinking an index created in 5.x.
This breaks search/get on the shrinked index because this setting is used to choose
whether `_uid` or `_id` field should be used as the primary key.
This commit fixes this bug by copying the setting in the shrinked index.
@jimczi jimczi added >bug :Data Management/Indices APIs APIs to create and manage indices and templates v6.3.0 labels Mar 22, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Contributor

@bleskes bleskes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if we have a qa test for this. I would prefer a real 5.6 index as an input.

@bleskes
Copy link
Contributor

bleskes commented Mar 22, 2018

I wonder if we have a qa test for this. I would prefer a real 5.6 index as an input.

I missed that this is exactly what you did. All good and sorry for the noise.

@jimczi jimczi merged commit 683bb1c into elastic:6.x Mar 22, 2018
@jimczi jimczi deleted the bug/shrink_mapping_single_type branch March 22, 2018 13:17
martijnvg added a commit that referenced this pull request Mar 26, 2018
* es/6.x: (29 commits)
  [Docs] Add rank_eval size parameter k (#29218)
  Docs: Update docs/index_.asciidoc (#29172)
  Docs: Link C++ client lib elasticlient (#28949)
  Docs: HighLevelRestClient#multiSearch (#29144)
  [DOCS] Remove ignore_z_value parameter link
  Add Z value support to geo_shape
  Change BroadcastResponse from ToXContentFragment to ToXContentObject (#28878)
  REST : Split `RestUpgradeAction` into two actions (#29124)
  [DOCS] Unregister repository instead of deleting it (#29206)
  Remove type casts in logging in server component (#28807)
  Add error file docs to important settings
  Add note to low-level client docs for DNS caching (#29213)
  testShrinkAfterUpgrade should only set mapping.single_type if bwc version > 5.5.0
  Harden periodically check to avoid endless flush loop (#29125)
  REST high-level client: add force merge API (#28896)
  Remove license information from README.textile (#29198)
  Decouple more classes from XContentBuilder and make builder strict (#29197)
  Propagate mapping.single_type setting on shrinked index (#29202)
  [Docs] Fix missing closing block in cluster/misc.asciidoc
  RankEvalRequest should implement IndicesRequest (#29188)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Data Management/Indices APIs APIs to create and manage indices and templates v6.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants