Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fix deb version to use tilde with prerelease versions #29000

Merged
merged 3 commits into from
Apr 26, 2018

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Mar 12, 2018

This commit converts the deb package to use tildes in place of dash in
the internal package version. This is only relevant for prerelease
versions of elasticsearch, and important for prerelease versions to
sort before released versions. Previously, this was not possible due to
problems with the underlying library used by the ospackage plugin, but
since a recent upgrade, it now works.

closes #21139

This commit converts the deb package to use tildes in place of dash in
the internal package version. This is only relevant for prerelease
versions of elasticsearch. Previously, this was not possible due to
problems with the underlying library used by the ospackage plugin, but
since a recent upgrade, it now works.

closes elastic#21139
@rjernst rjernst added >bug :Delivery/Build Build or test infrastructure labels Mar 12, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@rjernst
Copy link
Member Author

rjernst commented Mar 12, 2018

@elasticmachine run packaging tests

@rjernst
Copy link
Member Author

rjernst commented Mar 13, 2018

@elasticmachine run packaging tests

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. This keeps the "rc" part of our release in the upstream_version part of the version which is much more correct.

@rjernst rjernst merged commit 4cfca2f into elastic:master Apr 26, 2018
@rjernst rjernst deleted the deb_prerelease_version branch April 26, 2018 18:51
@rjernst rjernst added :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts and removed :Delivery/Build Build or test infrastructure labels Apr 26, 2018
@rjernst rjernst restored the deb_prerelease_version branch April 26, 2018 19:53
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Apr 26, 2018
This commit adds a changelog entry for the change in elastic#29000.
dnhatn added a commit that referenced this pull request Apr 27, 2018
* master: (24 commits)
  Watcher: Ensure mail message ids are unique per watch action (#30112)
  REST: Remove GET support for clear cache indices (#29525)
  SQL: Correct error message (#30138)
  Require acknowledgement to start_trial license (#30135)
  Fix a bug in FieldCapabilitiesRequest#equals and hashCode. (#30181)
  SQL: Add BinaryMathProcessor to named writeables list (#30127)
  Tests: Use buildDir as base for generated-resources (#30191)
  Fix SliceBuilderTests#testRandom failures
  Build: Fix deb version to use tilde with prerelease versions (#29000)
  Fix edge cases in CompositeKeyExtractorTests (#30175)
  Document time unit limitations for date histograms (#30177)
  Add support for field capabilities to the high-level REST client. (#29664)
  Remove licenses missed by the migration (#30128)
  [DOCS] Updates docker installation package details (#30110)
  Fix TermsSetQueryBuilder.doEquals() method (#29629)
  [Monitoring] Remove unhelpful Monitoring tests (#30144)
  [Test] Fix RenameProcessorTests.testRenameExistingFieldNullValue() (#29655)
  add copyright/scope configuration for intellij to Contributing Guide (#29688)
  [test] include oss tar in packaging tests (#30155)
  TEST: Update settings should go through cluster state (#29682)
  ...
rjernst added a commit that referenced this pull request May 2, 2018
This commit adds a changelog entry for the change in #29000.
@rjernst rjernst deleted the deb_prerelease_version branch January 20, 2019 19:34
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Delivery Meta label for Delivery team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading from 5.0.0-rc1 to stable might be broken on Debian
4 participants