-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle throws on tasks submitted to thread pools #28667
Merged
Merged
Commits on Feb 13, 2018
-
Handle throws on tasks submitted to thread pools
When we submit a task to a thread pool for asynchronous execution, we are returned a future. Since we submitted to go asynchronous, these futures are not inspected for failure (we would have to block a thread to do that). While we have on failure handlers for exceptions that are thrown during execution, we do not handle throwables that are not exceptions and these end up silently lost. This commit adds a check after the runnable returns that inspects the status of the future. If an unhandled throwable occurred during execution, this throwable is propogated out where it will land in the uncaught exception handler.
Configuration menu - View commit details
-
Copy full SHA for 1213d0b - Browse repository at this point
Copy the full SHA 1213d0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for de855ab - Browse repository at this point
Copy the full SHA de855abView commit details -
Configuration menu - View commit details
-
Copy full SHA for c725ed8 - Browse repository at this point
Copy the full SHA c725ed8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 778a3b4 - Browse repository at this point
Copy the full SHA 778a3b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5aad388 - Browse repository at this point
Copy the full SHA 5aad388View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80dca64 - Browse repository at this point
Copy the full SHA 80dca64View commit details
Commits on Feb 14, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f73323e - Browse repository at this point
Copy the full SHA f73323eView commit details
Commits on Feb 15, 2018
-
Merge branch 'master' into async-errors
* master: Backported synced-flush PR to v5.6.8 and v6.2.2 Move more XContent.createParser calls to non-deprecated version (elastic#28672) Move more XContent.createParser calls to non-deprecated version (elastic#28670) Build: Group archive and package distribution projects (elastic#28673) [DOCS] Add supported token filters [TEST] bump timeout in testFetchShardsSkipUnavailable to 5s Relax remote check for bwc project checkouts (elastic#28666) [TEST] Synchronize searcher list in IndexShardTests [TEST] packaging: function to collect debug info (elastic#28608) Compute declared versions in a static block Docs: Remove references to elasticsearch directory in plugins (elastic#28647) Remove snapshot conditional for bwc snapshots (elastic#28657) Removed redundant JSON object from Put Mapping docs (elastic#28514) Update threadpool.asciidoc target_response_time (elastic#28655)
Configuration menu - View commit details
-
Copy full SHA for 842f331 - Browse repository at this point
Copy the full SHA 842f331View commit details -
Merge branch 'master' into async-errors
* master: Add a note to the docs that _cat api `help` option cannot be used if an optional url param is used (elastic#28686) Lift error finding utility to exceptions helpers Change "tweet" type to "_doc" (elastic#28690) [Docs] Add missing word in nested.asciidoc (elastic#28507) Simplify the Translog constructor by always expecting an existing translog (elastic#28676) Upgrade t-digest to 3.2 (elastic#28295) (elastic#28305) Add comment explaining lazy declared versions
Configuration menu - View commit details
-
Copy full SHA for 79e3c07 - Browse repository at this point
Copy the full SHA 79e3c07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0321695 - Browse repository at this point
Copy the full SHA 0321695View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08375c2 - Browse repository at this point
Copy the full SHA 08375c2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.