Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle throws on tasks submitted to thread pools #28667

Merged
merged 11 commits into from
Feb 15, 2018

Commits on Feb 13, 2018

  1. Handle throws on tasks submitted to thread pools

    When we submit a task to a thread pool for asynchronous execution, we
    are returned a future. Since we submitted to go asynchronous, these
    futures are not inspected for failure (we would have to block a thread
    to do that). While we have on failure handlers for exceptions that are
    thrown during execution, we do not handle throwables that are not
    exceptions and these end up silently lost. This commit adds a check
    after the runnable returns that inspects the status of the future. If an
    unhandled throwable occurred during execution, this throwable is
    propogated out where it will land in the uncaught exception handler.
    jasontedor committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    1213d0b View commit details
    Browse the repository at this point in the history
  2. Checkstyle

    jasontedor committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    de855ab View commit details
    Browse the repository at this point in the history
  3. Licenese header

    jasontedor committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    c725ed8 View commit details
    Browse the repository at this point in the history
  4. Careful now

    jasontedor committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    778a3b4 View commit details
    Browse the repository at this point in the history
  5. Rework test

    jasontedor committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    5aad388 View commit details
    Browse the repository at this point in the history
  6. More simplification

    jasontedor committed Feb 13, 2018
    Configuration menu
    Copy the full SHA
    80dca64 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2018

  1. Safer test

    jasontedor committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    f73323e View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2018

  1. Merge branch 'master' into async-errors

    * master:
      Backported synced-flush PR to v5.6.8 and v6.2.2
      Move more XContent.createParser calls to non-deprecated version (elastic#28672)
      Move more XContent.createParser calls to non-deprecated version (elastic#28670)
      Build: Group archive and package distribution projects (elastic#28673)
      [DOCS] Add supported token filters
      [TEST] bump timeout in testFetchShardsSkipUnavailable to 5s
      Relax remote check for bwc project checkouts (elastic#28666)
      [TEST] Synchronize searcher list in IndexShardTests
      [TEST] packaging: function to collect debug info (elastic#28608)
      Compute declared versions in a static block
      Docs: Remove references to elasticsearch directory in plugins (elastic#28647)
      Remove snapshot conditional for bwc snapshots (elastic#28657)
      Removed redundant JSON object from Put Mapping docs (elastic#28514)
      Update threadpool.asciidoc target_response_time (elastic#28655)
    jasontedor committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    842f331 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' into async-errors

    * master:
      Add a note to the docs that _cat api `help` option cannot be used if an optional url param is used (elastic#28686)
      Lift error finding utility to exceptions helpers
      Change "tweet" type to "_doc" (elastic#28690)
      [Docs] Add missing word in nested.asciidoc (elastic#28507)
      Simplify the Translog constructor by always expecting an existing translog (elastic#28676)
      Upgrade t-digest to 3.2 (elastic#28295) (elastic#28305)
      Add comment explaining lazy declared versions
    jasontedor committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    79e3c07 View commit details
    Browse the repository at this point in the history
  3. Refactor

    jasontedor committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    0321695 View commit details
    Browse the repository at this point in the history
  4. Fix comments

    jasontedor committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    08375c2 View commit details
    Browse the repository at this point in the history