Plugins: Remove intermediate "elasticsearch" directory within plugin zips #28589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zips This commit removes the extra layer of all plugin files existing under "elasticsearch" within plugin zips. This simplifies building plugin zips and removes the need for special logic of modules vs plugins.
nik9000
reviewed
Feb 9, 2018
| @@ -822,26 +821,6 @@ public void testMissingDescriptor() throws Exception { | |||
| assertInstallCleaned(env.v2()); | |||
| } | |||
|
|
|||
| public void testMissingDirectory() throws Exception { | |||
There was a problem hiding this comment.
I think it'd be nice if we had a nice error message for folks that install a plugin with the directory.
nik9000
approved these changes
Feb 12, 2018
rjernst
added a commit
that referenced
this pull request
Feb 12, 2018
…zips (#28589) This commit removes the extra layer of all plugin files existing under "elasticsearch" within plugin zips. This simplifies building plugin zips and removes the need for special logic of modules vs plugins.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 13, 2018
This directory was removed from plugins in elastic#28589, but docs still referenced it. This commit cleans up the plugin author docs to no longer refer to it.
rjernst
added a commit
that referenced
this pull request
Feb 13, 2018
This directory was removed from plugins in #28589, but docs still referenced it. This commit cleans up the plugin author docs to no longer refer to it.
rjernst
added a commit
that referenced
this pull request
Feb 13, 2018
This directory was removed from plugins in #28589, but docs still referenced it. This commit cleans up the plugin author docs to no longer refer to it.
guruxu
pushed a commit
to rosette-api/rosette-elasticsearch-plugin
that referenced
this pull request
Aug 2, 2018
- update per elastic/elasticsearch#28589 - update curl calls with application/json type which seems to be required now - update docker test script to not swallow detectable errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the extra layer of all plugin files existing under
"elasticsearch" within plugin zips. This simplifies building plugin zips
and removes the need for special logic of modules vs plugins.