Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore empty completion input #28289

Closed
wants to merge 1 commit into from

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented Jan 18, 2018

This change makes sure that an empty completion input does not throw an IAE when indexing.
Instead the input is simply ignored.

Closes #23121

This change makes sure that an empty completion input does not throw an IAE when indexing.
Instead the input is simply ignored.

Closes elastic#23121
@mayya-sharipova
Copy link
Contributor

+1 LGTM

I was wondering if this input.length ==0 after the input has already been analyzed?

@jimczi jimczi added discuss and removed review labels Mar 19, 2018
@jimczi
Copy link
Contributor Author

jimczi commented Mar 19, 2018

cc @elastic/es-search-aggs

@jimczi
Copy link
Contributor Author

jimczi commented Apr 27, 2018

This pr is stalled because we need to decide if we want to ignore empty fields silently. There are some concerns that this change could hide bugs at ingestion if we simply ignore empty strings. I added the discuss label in order to discuss the different options.

@jimczi
Copy link
Contributor Author

jimczi commented May 18, 2018

Now that we have an _ignored field we can add the completion field to the list in order to indicate that the suggestion was ignored:
https://www.elastic.co/guide/en/elasticsearch/reference/master/mapping-ignored-field.html
I opened a new pr #30713 to implement this idea so I am closing this one.

@jimczi jimczi closed this May 18, 2018
@jimczi jimczi deleted the bug/empty_completion branch August 16, 2018 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants