Ignore empty completion input #28289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes sure that an empty completion input does not throw an IAE when indexing. Instead the input is simply ignored. Closes elastic#23121
jimczi
added
>bug
:Search Relevance/Suggesters
|
+1 LGTM I was wondering if this |
mayya-sharipova
approved these changes
Feb 1, 2018
|
cc @elastic/es-search-aggs |
|
This pr is stalled because we need to decide if we want to ignore empty fields silently. There are some concerns that this change could hide bugs at ingestion if we simply ignore empty strings. I added the discuss label in order to discuss the different options. |
ahzamali
approved these changes
May 18, 2018
|
Now that we have an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes sure that an empty completion input does not throw an IAE when indexing.
Instead the input is simply ignored.
Closes #23121