Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getting-started.asciidoc #28249

Closed
wants to merge 1 commit into from
Closed

Conversation

wr0ngc0degen
Copy link

since it's a JSON-style query request body it should be a POST not GET request

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

since it's a JSON-style query request body it should be a POST not GET request
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The verb is correct, and we use GET throughout the rest of this section too (see e.g. https://www.elastic.co/guide/en/elasticsearch/reference/current/_executing_searches.html) so this should remain as it is.

However, the following line does say that we "POST" the query which isn't right. I don't think we need to mention the HTTP verb in that sentence, so that's the fix I'd prefer.

Additionally, this change is opened against 6.1 instead of master because it came through the doc editor. Please could you rebase it against master and update the target branch to match?

@DaveCTurner DaveCTurner added >docs General docs changes v7.0.0 v6.3.0 labels Jan 17, 2018
@DaveCTurner DaveCTurner changed the base branch from 6.1 to master January 17, 2018 10:39
@DaveCTurner DaveCTurner changed the base branch from master to 6.1 January 17, 2018 10:40
@cbuescher
Copy link
Member

@wr0ngc0degen any interest in changing this PR like @DaveCTurner suggested to get this in? Otherwise I think we should close this.

@cbuescher
Copy link
Member

Closing, @wr0ngc0degen if you would like to make the changes suggested here, please reopen as a PR against master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants