Make sure that we don't detect files as maven coordinate when installing a plugin #28163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimczi
added
>bug
:Core/Infra/Plugins
rjernst
reviewed
Jan 10, 2018
| // has two colons, so it appears similar to maven coordinates | ||
| FileNotFoundException e = expectThrows(FileNotFoundException.class, () -> installPlugin("file:C:\\plugin.zip", env.v1())); | ||
| assertTrue(e.getMessage(), e.getMessage().startsWith("C:\\plugin.zip")); | ||
| } |
There was a problem hiding this comment.
Can you please use a filename that is a lot more explicit and unlikely to "accidentally" exist if on a windows box? And please run this test on windows (I'm a little worried we won't always get FileNotFoundException, for example getting an AccessDeniedException on some systems instead).
There was a problem hiding this comment.
Thanks, I randomized the directory name to test and changed the assertion to check the message of the exception only (I tested on windows server and got a FileNotFoundException consistently so I can put it back if you want):
0779d60
jimczi
added a commit
that referenced
this pull request
Jan 10, 2018
…ing a plugin This change makes sure that we don't detect a file path containing a ':' as a maven coordinate (e.g.: `file:C:\path\to\zip`)
jimczi
force-pushed
the
plugins_file_not_maven
branch
from
92856c0
to
8b6db34
Compare
jimczi
added a commit
that referenced
this pull request
Jan 10, 2018
jimczi
added a commit
that referenced
this pull request
Jan 10, 2018
…ing a plugin (#28163) * This change makes sure that we don't detect a file path containing a ':' as a maven coordinate (e.g.: `file:C:\path\to\zip`) * restore test muted on master
jasontedor
added a commit
that referenced
this pull request
Jan 11, 2018
* master: (43 commits) Rename core module to server (#28180) upgraded jna from 4.4.0-1 to 4.5.1 (#28183) [TEST] Do not call RandomizedTest.scaledRandomIntBetween from multiple threads Primary send safe commit in file-based recovery (#28038) [Docs] Correct response json in rank-eval.asciidoc Add scroll parameter to _reindex API (#28041) Include all sentences smaller than fragment_size in the unified highlighter (#28132) Modifies the JavaAPI docs related to AggregationBuilder [Docs] Improvements in script-fields.asciidoc (#28174) [Docs] Remove Kerberos/SPNEGO Shield plugin (#28019) Ignore null value for range field (#27845) (#28116) Fix environment variable substitutions in list setting (#28106) docs: Replaces indexed script java api docs with stored script api docs test: ensure we endup with a single segment Make sure that we don't detect files as maven coordinate when installing a plugin (#28163) [Tests] temporary disable meta plugin rest tests #28163 meta-plugin should install bin and config at the top level (#28162) Painless: Add public member read/write access test. (#28156) Docs: Clarify password protection support with keystore (#28157) [Docs] fix plugin properties inclusion for plugins authors ...
jasontedor
added a commit
that referenced
this pull request
Jan 11, 2018
* 6.x: (41 commits) Rename core module to server (#28190) [Test] Remove superfluous lines [Test] Add skip test for index range field with null values upgraded jna from 4.4.0-1 to 4.5.1 (#28183) [TEST] Do not call RandomizedTest.scaledRandomIntBetween from multiple threads [Docs] Correct response json in rank-eval.asciidoc Fix environment variable substitutions in list setting (#28106) Add scroll parameter to _reindex API (#28041) Include all sentences smaller than fragment_size in the unified highlighter (#28132) [Docs] Improvements in script-fields.asciidoc (#28174) [Docs] Remove Kerberos/SPNEGO Shield plugin (#28019) Ignore null value for range field (#27845) (#28116) docs: Replaces indexed script java api docs with stored script api docs test: ensure we endup with a single segment Make sure that we don't detect files as maven coordinate when installing a plugin (#28163) [Tests] temporary disable meta plugin rest tests #28163 meta-plugin should install bin and config at the top level (#28162) Painless: Add public member read/write access test. (#28156) Docs: Clarify password protection support with keystore (#28157) [Docs] fix plugin properties inclusion for plugins authors ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes sure that we don't detect a file path containing a ':' as
a maven coordinate (e.g.:
file:C:\path\to\zip)