Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add beta label to MSI on install Elasticsearch page #28126

Merged
merged 1 commit into from
Aug 22, 2018
Merged

Add beta label to MSI on install Elasticsearch page #28126

merged 1 commit into from
Aug 22, 2018

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Jan 7, 2018

The main installation instructions page for the Windows MSI installer includes a header at the top to indicate that the installer is in beta, but the Installing Elasticsearch page does not. This commit adds the beta label to the MSI entry within the installation options.

@russcam
Add beta label to MSI on install Elasticsearch page
c4a35a6 
The main installation instructions page for the Windows MSI installer includes a header at the top to indicate that the installer is in beta, but the Installing Elasticsearch page does not. This commit adds the beta label to the MSI entry within the installation options.
@jasontedor
Copy link
Member

Please add labels (including version labels).

@russcam
Copy link
Contributor Author

russcam commented Jan 8, 2018

@jasontedor Sure can do.

This needs to be applied to all versions; want me to add every version label?

@russcam russcam added the >docs General docs changes label Jan 8, 2018
@jasontedor
Copy link
Member

It shouldn’t need to be applied to all versions, but I can understand applying it to all active branches (and 6.0), so 5.6.6, 6.0.2, 6.1.2, 6.2.0, and 7.0.0 would be fine in that case.

@russcam
Copy link
Contributor Author

russcam commented Feb 16, 2018

@jasontedor I've added what I believe are the appropriate labels for this

jasontedor
jasontedor approved these changes Feb 16, 2018
View reviewed changes
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jasontedor jasontedor added v5.6.9 and removed v5.6.8 labels Feb 20, 2018
@colings86 colings86 added the :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts label Apr 24, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@javanna
Copy link
Member

javanna commented Aug 16, 2018

is this still relevant @russcam ?

@russcam
Copy link
Contributor Author

russcam commented Aug 17, 2018 •
edited
Loading

Yes it is @javanna. I can look at merging next week. Thanks for the ping!

@javanna
Copy link
Member

javanna commented Aug 17, 2018

thanks @russcam please do so, let me know if I can do anything to help getting it in.

@russcam russcam merged commit 07b3ff9 into elastic:master Aug 22, 2018
@russcam
Copy link
Contributor Author

russcam commented Aug 22, 2018

I've merged this into master, but wanted to double check before porting the change to other branches. I'm looking to pick to:

  • 5.5
  • 5.6
  • 6.4
  • 6.3
  • 6.2
  • 6.1
  • 6.0
  • 6.x

so that the change is reflected in docs for these minor versions. look OK?

@javanna
Copy link
Member

javanna commented Aug 22, 2018

sounds good to me @russcam

russcam added a commit that referenced this pull request Aug 23, 2018
@russcam
Add beta label to MSI on install Elasticsearch page (#28126)
90692e0 
The main installation instructions page for the Windows MSI installer includes a header at the top to indicate that the installer is in beta, but the Installing Elasticsearch page does not. This commit adds the beta label to the MSI entry within the installation options.

(cherry picked from commit 07b3ff9)
russcam added a commit that referenced this pull request Aug 23, 2018
@russcam
Add beta label to MSI on install Elasticsearch page (#28126)
29fc4a2 
The main installation instructions page for the Windows MSI installer includes a header at the top to indicate that the installer is in beta, but the Installing Elasticsearch page does not. This commit adds the beta label to the MSI entry within the installation options.

(cherry picked from commit 07b3ff9)
russcam added a commit that referenced this pull request Aug 23, 2018
@russcam
Add beta label to MSI on install Elasticsearch page (#28126)
9f25524 
The main installation instructions page for the Windows MSI installer includes a header at the top to indicate that the installer is in beta, but the Installing Elasticsearch page does not. This commit adds the beta label to the MSI entry within the installation options.

(cherry picked from commit 07b3ff9)
russcam added a commit that referenced this pull request Aug 23, 2018
@russcam
Add beta label to MSI on install Elasticsearch page (#28126)
b84ec1a 
The main installation instructions page for the Windows MSI installer includes a header at the top to indicate that the installer is in beta, but the Installing Elasticsearch page does not. This commit adds the beta label to the MSI entry within the installation options.

(cherry picked from commit 07b3ff9)
russcam added a commit that referenced this pull request Aug 23, 2018
@russcam
Add beta label to MSI on install Elasticsearch page (#28126)
1c10571 
The main installation instructions page for the Windows MSI installer includes a header at the top to indicate that the installer is in beta, but the Installing Elasticsearch page does not. This commit adds the beta label to the MSI entry within the installation options.

(cherry picked from commit 07b3ff9)
russcam added a commit that referenced this pull request Aug 23, 2018
@russcam
Add beta label to MSI on install Elasticsearch page (#28126)
8d661ed 
The main installation instructions page for the Windows MSI installer includes a header at the top to indicate that the installer is in beta, but the Installing Elasticsearch page does not. This commit adds the beta label to the MSI entry within the installation options.

(cherry picked from commit 07b3ff9)
russcam added a commit that referenced this pull request Aug 23, 2018
@russcam
Add beta label to MSI on install Elasticsearch page (#28126)
e9ba234 
The main installation instructions page for the Windows MSI installer includes a header at the top to indicate that the installer is in beta, but the Installing Elasticsearch page does not. This commit adds the beta label to the MSI entry within the installation options.

(cherry picked from commit 07b3ff9)
russcam added a commit that referenced this pull request Aug 23, 2018
@russcam
Add beta label to MSI on install Elasticsearch page (#28126)
d27bd36 
The main installation instructions page for the Windows MSI installer includes a header at the top to indicate that the installer is in beta, but the Installing Elasticsearch page does not. This commit adds the beta label to the MSI entry within the installation options.

(cherry picked from commit 07b3ff9)
@russcam
Copy link
Contributor Author

russcam commented Aug 23, 2018

Thanks @javanna, done.

@russcam russcam deleted the docs/install-msi-beta-label branch August 23, 2018 00:37
martijnvg added a commit that referenced this pull request Aug 24, 2018
@martijnvg
Merge remote-tracking branch 'es/6.x' into ccr-6.x
943caaf 
* es/6.x: (58 commits)
  [DOCS] Add docs for Application Privileges (#32635)
  Add versions 5.6.12 and 6.4.1
  [Rollup] Return empty response when aggs are missing (#32796)
  [TEST] Add some ACL yaml tests for Rollup (#33035)
  Test fix - GraphExploreResponseTests should not randomise array elements Closes #33086
  Use `addIfAbsent` instead of checking if an element is contained
  HLRC: Fix Compile Error From Missing Throws (#33083)
  [DOCS] Remove reload password from docs cf. #32889
  Use a dedicated ConnectionManger for RemoteClusterConnection (#32988)
  Watcher: Improve error messages for CronEvalTool (#32800)
  HLRC: Add ML Get Buckets API (#33056)
  Change query field expansion (#33020)
  Search: Support of wildcard on docvalue_fields (#32980)
  Add beta label to MSI on install Elasticsearch page (#28126)
  SQL: skip uppercasing/lowercasing function tests for AZ locales as well (#32910)
  [DOCS] Drafts Elasticsearch 6.4.0 release notes (#33039)
  Fix the default pom file name (#33063)
  Fix backport of switch ml basic tests to new style Requests (#32483)
  Switch ml basic tests to new style Requests (#32483)
  Switch some watcher tests to new style Requests (#33044)
  ...
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasontedor jasontedor jasontedor approved these changes

Assignees
No one assigned
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >docs General docs changes Team:Delivery Meta label for Delivery team v5.5.4 v5.6.9 v6.0.3 v6.1.5 v6.2.5 v6.3.3 v6.4.0 v6.5.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@russcam @jasontedor @elasticmachine @javanna @colings86 @mark-vieira @jimczi