Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Fix order of nodes usage example #27611

Merged
merged 3 commits into from
Dec 1, 2017
Merged

[Docs] Fix order of nodes usage example #27611

merged 3 commits into from
Dec 1, 2017

Conversation

sshling
Copy link
Contributor

@sshling sshling commented Dec 1, 2017

fix as description , The first ... The secone...

@karmi
Copy link
Contributor

karmi commented Dec 1, 2017

Hi @sshling, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@sshling
Copy link
Contributor Author

sshling commented Dec 1, 2017

sorry , I had add another e-mails into Github profile

cbuescher
cbuescher approved these changes Dec 1, 2017
View reviewed changes
Copy link
Member

@cbuescher cbuescher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sshling thanks for correcting this. I will merge this into the currently active documentation branches.

@cbuescher cbuescher merged commit 756e170 into elastic:master Dec 1, 2017
cbuescher pushed a commit that referenced this pull request Dec 1, 2017
@sshling @cbuescher
[Docs] Fix order of nodes usage example (#27611)
cca92ab
cbuescher pushed a commit that referenced this pull request Dec 1, 2017
@sshling @cbuescher
[Docs] Fix order of nodes usage example (#27611)
6fb10e4
cbuescher pushed a commit that referenced this pull request Dec 1, 2017
@sshling @cbuescher
[Docs] Fix order of nodes usage example (#27611)
2794dff
@cbuescher cbuescher changed the title Minor edit [Docs] Fix order of nodes usage example Dec 1, 2017
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

clintongormley added a commit to clintongormley/elasticsearch that referenced this pull request Dec 1, 2017
@clintongormley
elastic#27611 broke the docs tests because $node_name in the URL doesn't
303c77d 
seem to be replaced.

Changing this to a * to match all nodes seems to fix the test
@clintongormley clintongormley mentioned this pull request Dec 1, 2017
Merged
clintongormley added a commit that referenced this pull request Dec 1, 2017
@clintongormley
Fix cluster usage docs test
bf9e208 
#27611 broke the docs tests because $node_name in the URL doesn't (#27616)seem to be replaced.

Changing this to a * to match all nodes seems to fix the test
cbuescher pushed a commit that referenced this pull request Dec 1, 2017
@clintongormley @cbuescher
Fix cluster usage docs test
e1aa6e2 
#27611 broke the docs tests because $node_name in the URL doesn't (#27616)seem to be replaced.

Changing this to a * to match all nodes seems to fix the test
cbuescher pushed a commit that referenced this pull request Dec 1, 2017
@clintongormley @cbuescher
Fix cluster usage docs test
4a5a97c 
#27611 broke the docs tests because $node_name in the URL doesn't (#27616)seem to be replaced.

Changing this to a * to match all nodes seems to fix the test
cbuescher pushed a commit that referenced this pull request Dec 1, 2017
@clintongormley @cbuescher
Fix cluster usage docs test
d951bbf 
#27611 broke the docs tests because $node_name in the URL doesn't (#27616)seem to be replaced.

Changing this to a * to match all nodes seems to fix the test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbuescher cbuescher cbuescher approved these changes

Assignees
No one assigned
Labels
>docs General docs changes v6.0.2 v6.1.0 v6.2.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sshling @karmi @elasticmachine @cbuescher @colings86