Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade AWS SDK Jackson Databind to 2.6.7.1 #27361

Merged

Conversation

jasontedor
Copy link
Member

The AWS SDK has a transitive dependency on Jackson Databind. While the AWS SDK was recently upgraded, the Jackson Databind dependency was not pulled along with it to the version that the AWS SDK depends on. This commit upgrades the dependencies for discovery-ec2 and repository-s3 plugins to match versions on the AWS SDK transitive dependencies.

Closes #27359, relates #27278

@jasontedor jasontedor requested a review from tlrx November 13, 2017 15:15
@jasontedor jasontedor changed the title Upgrade AWS SDK Jackson Databind to 2.7.6.1 Upgrade AWS SDK Jackson Databind to 2.6.7.1 Nov 13, 2017
The AWS SDK has a transitive dependency on Jackson Databind. While the
AWS SDK was recently upgraded, the Jackson Databind dependency was not
pulled along with it to the version that the AWS SDK depends on. This
commit upgrades the dependencies for discovery-ec2 and repository-s3
plugins to match versions on the AWS SDK transitive dependencies.
@jasontedor jasontedor force-pushed the upgrade-aws-sdk-jackson-databind-2.7.6.1 branch from 819c570 to c67fb80 Compare November 13, 2017 15:36
Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I manually tested repository-s3 but I don't have the knowledge nor the time to test discovery-ec2 so if CI is happy, I'm happy.

@jasontedor jasontedor merged commit d375cef into elastic:master Nov 13, 2017
jasontedor added a commit that referenced this pull request Nov 13, 2017
The AWS SDK has a transitive dependency on Jackson Databind. While the
AWS SDK was recently upgraded, the Jackson Databind dependency was not
pulled along with it to the version that the AWS SDK depends on. This
commit upgrades the dependencies for discovery-ec2 and repository-s3
plugins to match versions on the AWS SDK transitive dependencies.

Relates #27361
@jasontedor jasontedor deleted the upgrade-aws-sdk-jackson-databind-2.7.6.1 branch November 13, 2017 17:58
@jasontedor
Copy link
Member Author

Thanks for reviewing and testing repository-s3 @tlrx.

jasontedor added a commit that referenced this pull request Nov 14, 2017
The AWS SDK has a transitive dependency on Jackson Databind. While the
AWS SDK was recently upgraded, the Jackson Databind dependency was not
pulled along with it to the version that the AWS SDK depends on. This
commit upgrades the dependencies for discovery-ec2 and repository-s3
plugins to match versions on the AWS SDK transitive dependencies.

Relates #27361
tlrx pushed a commit that referenced this pull request Nov 14, 2017
The AWS SDK has a transitive dependency on Jackson Databind. While the
AWS SDK was recently upgraded, the Jackson Databind dependency was not
pulled along with it to the version that the AWS SDK depends on. This
commit upgrades the dependencies for discovery-ec2 and repository-s3
plugins to match versions on the AWS SDK transitive dependencies.

Relates #27361
@tlrx
Copy link
Member

tlrx commented Nov 14, 2017

This change has been backported to 5.6.5, 6.0.1, 6.1.0 and master.

@tlrx tlrx mentioned this pull request Nov 20, 2017
@clintongormley clintongormley added :Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs and removed :Plugin Discovery EC2 labels Feb 13, 2018
@jpountz jpountz removed the :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs label Jan 29, 2019
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure >upgrade v5.6.5 v6.0.1 v6.1.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants