Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading incorrect for in loop in painless documentation. #27195

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Misleading incorrect for in loop in painless documentation. #27195

merged 1 commit into from
Oct 31, 2017

Conversation

zarucki
Copy link

@zarucki zarucki commented Oct 31, 2017

Just small error in documentation. Without it you get weird and confusing invalid sequence of tokens near [':']. error. On this page it is correct.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@talevy
Copy link
Contributor

talevy commented Oct 31, 2017

thank you for catching that @zarucki! would you mind signing our CLA so that we can properly merge this in?

@talevy talevy self-requested a review October 31, 2017 20:58
@zarucki
Copy link
Author

zarucki commented Oct 31, 2017

Hey. I've signed the CLA. It is my first time signing such thing, I hope I did it properly.

Copy link
Contributor

@talevy talevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! LGTM

@talevy talevy merged commit 7993de5 into elastic:5.6 Oct 31, 2017
@zarucki zarucki deleted the patch-1 branch October 31, 2017 23:03
@clintongormley clintongormley added :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache and removed :Plugin Lang Painless labels Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >docs General docs changes v5.6.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants