Fix division by zero in phrase suggester that causes assertion to fail #27149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
:Search Relevance/Suggesters
jimczi
approved these changes
Oct 27, 2017
There was a problem hiding this comment.
Considering that this value works only with a single segment I wonder if we should remove it entirely from the formula. There is a related PR #27125 that wants to modify the formula so I think we can continue this discussion there and just fix the test assertion with this PR. LGTM for the fix until we decide what to do with this signal.
martijnvg
force-pushed
the
phrase_suggester_tiny_index_egde_case
branch
from
d606e8b to
c406a91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.