-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tie-break shard path decision based on total number of shards on path #27039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now if the number of shards for a particular index is equal across the data paths, we tie-break on space. This changes to tie-break first on the total number of shards for each path, and then, if that is the same, on the usable bytes. Relates to elastic#26654 (it's a follow-up)
This was referenced Oct 19, 2017
s1monw
approved these changes
Oct 24, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks Simon! |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Oct 26, 2017
* master: Ignore .DS_Store files on macOS Docs: Fix ingest geoip config location (elastic#27110) Adjust SHA-512 supported format on plugin install Make ShardSearchTarget optional when parsing ShardSearchFailure (elastic#27078) [Docs] Clarify mapping `index` option default (elastic#27104) Decouple BulkProcessor from ThreadPool (elastic#26727) Stats to record how often the ClusterState diff mechanism is used successfully (elastic#26973) Tie-break shard path decision based on total number of shards on path (elastic#27039)
lcawl
added
:Search/Search
Search-related issues that do not fall into other categories
and removed
:Allocation
labels
Feb 13, 2018
clintongormley
added
:Distributed Indexing/Distributed
A catch all label for anything in the Distributed Area. Please avoid if you can.
and removed
:Search/Search
Search-related issues that do not fall into other categories
labels
Feb 13, 2018
@dakrone hi, I found the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Indexing/Distributed
A catch all label for anything in the Distributed Area. Please avoid if you can.
>enhancement
v6.1.0
v7.0.0-beta1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if the number of shards for a particular index is equal across the
data paths, we tie-break on space. This changes to tie-break first on the total
number of shards for each path, and then, if that is the same, on the usable
bytes.
Relates to #26654 (it's a follow-up)