Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tie-break shard path decision based on total number of shards on path #27039

Merged
merged 1 commit into from
Oct 24, 2017

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Oct 18, 2017

Right now if the number of shards for a particular index is equal across the
data paths, we tie-break on space. This changes to tie-break first on the total
number of shards for each path, and then, if that is the same, on the usable
bytes.

Relates to #26654 (it's a follow-up)

Right now if the number of shards for a particular index is equal across the
data paths, we tie-break on space. This changes to tie-break first on the total
number of shards for each path, and then, if that is the same, on the usable
bytes.

Relates to elastic#26654 (it's a follow-up)
Copy link
Contributor

@s1monw s1monw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dakrone dakrone merged commit 6bc7024 into elastic:master Oct 24, 2017
dakrone added a commit that referenced this pull request Oct 24, 2017
…#27039)

Right now if the number of shards for a particular index is equal across the
data paths, we tie-break on space. This changes to tie-break first on the total
number of shards for each path, and then, if that is the same, on the usable
bytes.

Relates to #26654 (it's a follow-up)
@dakrone
Copy link
Member Author

dakrone commented Oct 24, 2017

Thanks Simon!

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Oct 26, 2017
* master:
  Ignore .DS_Store files on macOS
  Docs: Fix ingest geoip config location (elastic#27110)
  Adjust SHA-512 supported format on plugin install
  Make ShardSearchTarget optional when parsing ShardSearchFailure (elastic#27078)
  [Docs] Clarify mapping `index` option default (elastic#27104)
  Decouple BulkProcessor from ThreadPool (elastic#26727)
  Stats to record how often the ClusterState diff mechanism is used successfully (elastic#26973)
  Tie-break shard path decision based on total number of shards on path (elastic#27039)
@dakrone dakrone deleted the tie-break-on-shard-count branch December 13, 2017 20:37
@lcawl lcawl added :Search/Search Search-related issues that do not fall into other categories and removed :Allocation labels Feb 13, 2018
@clintongormley clintongormley added :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. and removed :Search/Search Search-related issues that do not fall into other categories labels Feb 13, 2018
@gf53520
Copy link

gf53520 commented Nov 12, 2020

@dakrone hi, I found the dataPathToShardCount is not the data path to total shards accross all indices. Am I wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >enhancement v6.1.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants