Limit the number of expanded fields it query_string and simple_query_string #26541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…string This limits the number of automatically expanded fields for the "all fields" mode (`"default_field": "*"`) for the `query_string` and `simple_query_string` queries to 1024 fields. Resolves elastic#25105
dakrone
added
:Search/Search
jimczi
approved these changes
Sep 8, 2017
|
@dakrone is there a limit for |
jimczi
added a commit
that referenced
this pull request
Oct 30, 2017
…s that can be queried at once in the multi_match query.
jasontedor
added a commit
that referenced
this pull request
Oct 30, 2017
* master: Refactor internal engine [Docs] #26541: add warning regarding the limit on the number of fields that can be queried at once in the multi_match query. [Docs] Fix note in bucket_selector [Docs] Fix indentation of examples (#27168) [Docs] Clarify `span_not` query behavior for non-overlapping matches (#27150) [Docs] Remove first person "I" from getting started (#27155)
|
@jimczi so metricbeat creates more than 1024 fields, which is causing ES to return errors when Kibana sends search requests that expand to all fields. Initially we thought setting the Any ideas how we can handle this gracefully for multi_match? |
Can you grab the existing value of |
|
@dakrone They would need to figure out which index to grab it from based on the pattern. |
|
And the |
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Oct 26, 2018
Starting with Elasticsearch 7.0, we limit the number of automatically expanded
fields for the "all fields" mode ("default_field": "*") for the query_string and
simple_query_string queries to 1024 fields (see elastic#26541). This change adds a
deprecation warning to the QueryParserHelper where in the next major version we
will throw an error to warn users of the upcoming change.
Relates to elastic#26541
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Oct 26, 2018
Adds a note to warn users about the limit introduced in elastic#26541.
cbuescher
pushed a commit
that referenced
this pull request
Oct 29, 2018
Starting with Elasticsearch 7.0, we limit the number of automatically expanded
fields for the "all fields" mode ("default_field": "*") for the query_string and
simple_query_string queries to 1024 fields (see #26541). This change adds a
deprecation warning to the QueryParserHelper where in the next major version we
will throw an error to warn users of the upcoming change.
Relates to #26541
cbuescher
pushed a commit
that referenced
this pull request
Oct 29, 2018
Adds a note to warn users about the limit introduced in #26541.
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Adds a note to warn users about the limit introduced in #26541.
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Nov 6, 2018
Currently we introduced a hard limit of 1024 to the number of fields a query can be expanded to in elastic#26541. Instead of using a hard limit, we should make this configurable. This change removes the hard limit check and uses the existing `max_clause_count` setting instead. Closes elastic#34778
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This limits the number of automatically expanded fields for the "all fields"
mode (
"default_field": "*") for thequery_stringandsimple_query_stringqueries to 1024 fields.
Resolves #25105