Make locale parsing less lenient. #26361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
added
>bug
v6.0.0
:Search Foundations/Mapping
The `locale` field of `date` fields accepts almost any string and unknown locales are simply ignored, which is trappy. We should fail on unknown languages or countries. This commit also makes `-` an accepted separator in addition to `_` since `-` is the recommended separator (https://tools.ietf.org/html/rfc5646#section-2.1). `_` is probably still worth supporting since it is the separator used by `Locale#toString()`.
jpountz
force-pushed
the
fix/locale-parsing
branch
from
c64e958 to
e63f10d
Compare
nik9000
approved these changes
Aug 24, 2017
|
I'll add a note to the 6.0 migration docs when backporting. |
jpountz
added a commit
that referenced
this pull request
Aug 28, 2017
The `locale` field of `date` fields accepts almost any string and unknown locales are simply ignored, which is trappy. We should fail on unknown languages or countries. This commit also makes `-` an accepted separator in addition to `_` since `-` is the recommended separator (https://tools.ietf.org/html/rfc5646#section-2.1). `_` is probably still worth supporting since it is the separator used by `Locale#toString()`.
jpountz
added a commit
that referenced
this pull request
Aug 28, 2017
The `locale` field of `date` fields accepts almost any string and unknown locales are simply ignored, which is trappy. We should fail on unknown languages or countries. This commit also makes `-` an accepted separator in addition to `_` since `-` is the recommended separator (https://tools.ietf.org/html/rfc5646#section-2.1). `_` is probably still worth supporting since it is the separator used by `Locale#toString()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
localefield ofdatefields accepts almost any string and unknownlocales are simply ignored, which is trappy. We should fail on unknown languages
or countries.
This commit also makes
-an accepted separator in addition to_since-is the recommended separator (https://tools.ietf.org/html/rfc5646#section-2.1).
_is probably still worth supporting since it is the separator used byLocale#toString().