Docs: Use single-node discovery.type for dev example #26289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the single node, dev example, the `discovery.type=single-node`[1] is a perfect fit and makes the example shorter and more self explanatory. [1] elastic#23595 [2] elastic#23598
|
cc @Jarpy |
|
@jasontedor are we ok with this? |
jasontedor
requested changes
Sep 13, 2017
| @@ -49,7 +49,7 @@ Elasticsearch can be quickly started for development or testing use with the fol | |||
|
|
|||
| ["source","sh",subs="attributes"] | |||
| -------------------------------------------- | |||
| docker run -p 9200:9200 -e "http.host=0.0.0.0" -e "transport.host=127.0.0.1" {docker-image} | |||
| docker run -p 9200:9200 -e "discovery.type=single-node" {docker-image} | |||
There was a problem hiding this comment.
I think that the transport port should be published too.
There was a problem hiding this comment.
@jasontedor Thanks for the review! This setting would be used only in the dev mode section of the elasticsearch docker documentation.
Since using this discovery.type doesn't allow clusters, what is the importance of setting the transport.tcp.port or transport.publish_port?
There was a problem hiding this comment.
A use-case is to test the usage of the transport client.
There was a problem hiding this comment.
Ah I see you mean adding -p 9300:9300 right?
There was a problem hiding this comment.
@jasontedor Addressed in 42f21a8
Exposing the transport port helps testing of the transport client. Relates: elastic#26289 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the single node, dev example, the
discovery.type=single-node[1] isa perfect fit and makes the example shorter and more self explanatory.
[1] #23595
[2] #23598