Evaluate settings values before passing it to task closure #26243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The secure settings tool reads from stdIn and we use a closure to provide a value for this. Yet, we evaluate they value too late and end up with the last provided value for all keys.
s1monw
added
>bug
:Delivery/Build
nik9000
approved these changes
Aug 16, 2017
|
Silly groovy. |
s1monw
added a commit
that referenced
this pull request
Aug 16, 2017
The secure settings tool reads from stdIn and we use a closure to provide a value for this. Yet, we evaluate they value too late and end up with the last provided value for all keys.
s1monw
added a commit
that referenced
this pull request
Aug 16, 2017
The secure settings tool reads from stdIn and we use a closure to provide a value for this. Yet, we evaluate they value too late and end up with the last provided value for all keys.
s1monw
added a commit
that referenced
this pull request
Aug 16, 2017
The secure settings tool reads from stdIn and we use a closure to provide a value for this. Yet, we evaluate they value too late and end up with the last provided value for all keys.
colings86
added
6.0.0-beta2
v6.0.0-beta2
v5.6.0
and removed
v6.0.0
6.0.0-beta2
v5.6.1
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The secure settings tool reads from stdIn and we use a closure to
provide a value for this. Yet, we evaluate they value too late and end up
with the last provided value for all keys.